Skip to content

src: document required else block at src/node_platform.cc#34688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juanarbol wants to merge 1 commit into from
Closed

src: document required else block at src/node_platform.cc #34688

juanarbol wants to merge 1 commit into from

Conversation

@juanarbol
Copy link
Member

@juanarboljuanarbol commented Aug 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 9, 2020
addaleax
addaleax requested changes Aug 9, 2020
View reviewed changes
Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not redundant because it moves the task out of the InternalCallbackScope in the case in which env is available.

@BridgeAR
Copy link
Member

BridgeAR commented Aug 9, 2020

@addaleax since the code is now run after the if statement, does it not behave the same as before?

@addaleax
Copy link
Member

addaleax commented Aug 9, 2020•
edited
Loading

@BridgeAR No – this is als the cause of the failures in the WASI tests here, I assume.

More generally, in C++

if (x){some_variable a; do_something()} else{do_something()}

and

if (x){some_variable a} do_something();

are not equivalent if the constructor/destructor of a influence do_something() in some way (which is the case here).

@juanarbol
Copy link
MemberAuthor

juanarbol commented Aug 9, 2020

Hey @addaleax thank you!! I was asking why it did break WASI tests.

Closing.

@addaleax
Copy link
Member

addaleax commented Aug 9, 2020

@juanarbol Fwiw, you’re not the first one who ran into this, so it might be worth adding a comment here that this is intentional (especially considering that this PR already had 4 approvals)

@juanarboljuanarbol reopened this Aug 10, 2020
Nelias
Nelias suggested changes Aug 13, 2020
View reviewed changes
@juanarboljuanarbolforce-pushed the juanarbol/remove-else-block branch from 4209ff9 to 24fba59CompareAugust 24, 2020 16:16
@juanarboljuanarbol changed the title src: remove redundant else blocksrc: document required else block at src/node_platform.ccAug 24, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32913/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32919/

This was referenced Aug 25, 2020
Open
Open
Open
@juanarboljuanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33293/

@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2020
@github-actionsgithub-actionsbot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2020
@addaleax
Copy link
Member

addaleax commented Sep 30, 2020

Landed in 535989e

addaleax pushed a commit that referenced this pull request Sep 30, 2020
@juanarbol@addaleax
src: document required else block at src/node_platform.cc
535989e
PR-URL: #34688 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@juanarbol@danielleadams
src: document required else block at src/node_platform.cc
4aed176
PR-URL: #34688 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Oct 6, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@juanarbol@joesepi
src: document required else block at src/node_platform.cc
089b432
PR-URL: nodejs#34688 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@juanarboljuanarbol deleted the juanarbol/remove-else-block branch January 19, 2021 16:27
@targostargos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+3 more reviewers

@NeliasNeliasNelias requested changes

@devnexendevnexendevnexen approved these changes

@yashLadhayashLadhayashLadha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@juanarbol@BridgeAR@addaleax@nodejs-github-bot@jasnell@lpinca@devnexen@gireeshpunathil@yashLadha@Nelias@targos