V14.13.1 proposal#35525

danielleadams · 2020-10-06T17:57:54Z

2020-10-07, Version 14.13.1 (Current), @BethGriggs prepared by @danielleadams

Notable Changes

fs:
- remove experimental from rmdir recursive (Benjamin Coe) #35171

Commits

[f36476d9d6] - build: fix CQ after latest ncu release (Mary Marchini) #35468
[7dc6b2fac7] - build: add support for section ordering (Gabriel Schulhof) #35272
[05e08bdf13] - console: add Symbol.toStringTag property (Leko) #35399
[a01154e3fd] - crypto: fix KeyObject garbage collection (Anna Henningsen) #35481
[1f15e34dc8] - crypto: set env values in KeyObject Deserialize method (ThakurKarthik) #35416
[85062b3aad] - deps: update llhttp to 2.1.3 (Fedor Indutny) #35435
[a995dd7a89] - doc: revise introductory child_process text (Rich Trott) #35344
[6585b161ba] - doc: improve eventLoopUtilization documentation (Andrey Pechkurov) #35479
[f08577c4a6] - doc: update AUTHORS list (Anna Henningsen) #35280
[91ef862365] - doc: mention adding YAML for APIs in PR contributing guide (Denys Otrishko) #35459
[885840b543] - doc: adopt MDN style for kbd elements (Rich Trott) #35460
[1313c8c33a] - doc: update sxa's email address to Red Hat from IBM (Stewart X Addison) #35442
[3f95440334] - doc: fix conditional exports flag removal version (Antoine du Hamel) #35428
[e40876a5e5] - doc: specify how to detect EOF (Luigi Pinca) #35445
[541ce17386] - doc: add entry to console.timeEnd() changes array (Luigi Pinca) #35441
[38a5715c1a] - doc: avoid using deprecated connection property (Luigi Pinca) #35439
[862b75d35e] - doc: added details around console.timeEnd changes (Yash Ladha) #35027
[4dbb3a91fe] - doc: copyedit packages.md (Rich Trott) #35427
[368a3ae415] - doc: update contact information for @BethGriggs (Beth Griggs) #35451
[a11ddee8b9] - doc: update contact information for richardlau (Richard Lau) #35450
[35b62ef0a7] - doc: importable node protocol URLs (Bradley Meck) #35434
[95c62a1dca] - doc: copyedit esm.md (Rich Trott) #35414
[86f2f83a2f] - doc: implement fancier rendering for keys (Rich Trott) #35400
[d6427886b8] - doc: unhide resolver spec (Guy Bedford) #35358
[5a730b5def] - doc: sort md references in ASCII order (Antoine du Hamel) #35191
[ce789f1ca4] - doc: use .md extension for internal links (Antoine du Hamel) #35191
[79e3e5008d] - doc: update example ICU URL (Daijiro Wachi) #35373
[998b24ef17] - doc: align to function signature (anlex N) #34930
[af360ace37] - doc: make minor edits for consistency (Rich Trott) #35377
[53e27b3f67] - doc,esm: add history support info (Antoine du Hamel) #35395
[91b820e939] - esm: use "node:" namespace for builtins (Guy Bedford) #35387
[541be526c3] - fs: do not throw exception after creating FSReqCallback (Anna Henningsen) #35487
[f29451dece] - fs: simplify realpathSync (himself65) #35413
[fcbdb0686d] - fs: remove experimental from rmdir recursive (Benjamin Coe) #35171
[e4a4f81d19] - fs: use Promise.resolve from primordials (Michaël Zasso) #35379
[8e3a81eed9] - http2,tls: store WriteWrap using BaseObjectPtr (Anna Henningsen) #35488
[62ddc77a5b] - meta: add nodejs/streams to CODEOWNERS (Matteo Collina) #35411
[23022066ec] - meta: add startup team in CODEOWNERS (Joyee Cheung) #35406
[0ac5fa703e] - module: update to [email protected] (Guy Bedford) #35501
[5c879a97e6] - module: fix builtin reexport tracing (Guy Bedford) #35500
[f23a0e250c] - module: refine module type mismatch error cases (Guy Bedford) #35426
[3f62f997a2] - src: more idiomatic error pattern in node_wasi (James M Snell) #35493
[392c8815fe] - src: use env->ThrowUVException in pipe_wrap (James M Snell) #35493
[e09f7f023a] - src: limit GetProcessTitle() result to 1MB (Anna Henningsen) #35492
[fbb9dd9ac9] - src: fix aliased buffer import warning in env.h (Yash Ladha) #35436
[7bbf8ee256] - src: remove invalid ToLocalChecked in EmitBeforeExit (Anna Henningsen) #35484
[5a85d4f2c6] - src: make MakeCallback() check can_call_into_js before getting method (Anna Henningsen) #35424
[4aed176b68] - src: document required else block at src/node_platform.cc (Juan José Arboleda) #34688
[552ebafd06] - test: update wpt tests for encoding (Daijiro Wachi) #35330
[27cd99b217] - test: improve test coverage for eventtarget (Juan José Arboleda) #33733
[5790c40c32] - tools: add missing uv_setup_argv() calls (Anna Henningsen) #35491
[f499302ac0] - tools: fix typo in error message (Antoine du Hamel) #35417
[5f1d792a09] - tools: update gyp to v0.5.0 (Ujjwal Sharma) #32698
[ad8fce6e61] - tools: update gyp to v0.4.0 (Ujjwal Sharma) #32698
[3e75907dea] - tools: update gyp-next to v0.3.0 (Ujjwal Sharma) #32698
[7361a3fd1a] - tools: update gyp-next to v0.2.1 (Ujjwal Sharma) #32698
[190d46bdde] - tools: update gyp to 0.2.0 (Ujjwal Sharma) #32698
[166f14ac98] - tools: check links in api docs (Antoine du Hamel) #35191
[a4e5a3af85] - tools: exclude gyp from markdown link checker (Michaël Zasso) #35423
[4d29fb56f2] - tools: add pythonenv to .gitignore (Michaël Zasso) #35389
[6e9e5c3381] - tools,doc: fix broken link in module.html (Rich Trott) #35446

* We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere. * When referring to functions, add _()_ to indicate that. * Remove backticks from non-code _destroyed_. PR-URL: #35377 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #35387 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

PR-URL: #35379 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #34930 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

GitHub Codespaces installs a copy of Python 3.8 in the repository. PR-URL: #35389 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #35373 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #34688 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

The changelog format used in gyp-next does not comply to the rules. PR-URL: #35423 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Adds support for using a section ordering file with the gold linker. This makes it possible to reorder functions in a build to optimize for a specific workload. `hfsort` is a tool that can be used to generate such a file from perf- recorded last branch record (LBR) data by running Node.js as `node --perf-basic-prof`. Refs: https://github.com/facebook/hhvm/tree/9966d482c19c6120c621c6f3896525fb19fb3842/hphp/tools/hfsort Refs: https://software.intel.com/content/www/us/en/develop/articles/runtime-optimization-blueprint-IA-optimization-with-last-branch-record.html Refs: #16891 Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #35272 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #35426 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Myles Borins <[email protected]>

This helps catch broken links as part of the test suite. This also improves the user experience when browsing the markdown files. PR-URL: #35191Fixes: #35189 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Refs: #35244 PR-URL: #35191Fixes: #35189 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Fixes: #35189 PR-URL: #35191 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Add Symbol.toStringTag property to console object to follow WPT changes Update WPT status of console and the repl test case Refs: web-platform-tests/wpt#24717 PR-URL: #35399 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #35358 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: #35400 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>

This provides a number of minor style adjustments and small corrections to esm.md text. Co-authored-by: Guy Bedford <[email protected]> PR-URL: #35414 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit. PR-URL: #35468 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>

PR-URL: #35434 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jan Krems <[email protected]>

PR-URL: #35450 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: #35406Fixes: #35215 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: #35451 Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Some minor adjustments, mostly moving things to present tense and avoiding the ambiguity of _may_. Refs: #35370 (comment) PR-URL: #35427 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>

Update tools/doc/type-parser.js with correct URL for the module.SourceMap class. This fixes a broken link in our documentation. PR-URL: #35446 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

There is a check for this in the inner `MakeCallback()` function called by it, but since the `Get()` call here can also result in a call into JS, we should ideally check the flag before that. PR-URL: #35424 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Fixes: #35263 PR-URL: #35416 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Since PR #29251 is merged into master, the implementation of `console.timeEnd` is not to print the milliseconds on the stdout but instead print a more readable time unit on the console. For example if the total time comes out to be 3456 milliseconds, it will be printed as 3.45 seconds so that it is much more readable and consistent. PR-URL: #35027Fixes: #35011 Refs: #29251 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Refs: #34278 PR-URL: #35171 Reviewed-By: Christopher Hiller <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

These objects don’t hold any resources on the event loop, so they should be weak objects that can be garbage collected when nothing refers to them anymore. PR-URL: #35481 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This call can fail, we should not use `.ToLocalChecked()` here. In the long run, we should use variants of `EmitExit()` and `EmitBeforeExit()` that avoid this problem by properly propagating empty `MaybeLocal`s. Example failure: 21:07:17 not ok 2564 parallel/test-worker-terminate-source-map 21:07:17 --- 21:07:17 duration_ms: 0.385 21:07:17 severity: crashed 21:07:17 exitcode: -6 21:07:17 stack: |- 21:07:17 FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal. 21:07:17 1: 0x1012f04a5 node::Abort() (.cold.1) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 2: 0x1000b52d9 node::Abort() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 3: 0x1000b543f node::OnFatalError(char const*, char const*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 4: 0x1001ffd70 v8::V8::ToLocalEmpty() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 5: 0x1000079b8 node::EmitBeforeExit(node::Environment*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 6: 0x100156fea node::worker::Worker::Run() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 7: 0x10015a4d2 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node] 21:07:17 8: 0x7fff72fe7109 _pthread_start [/usr/lib/system/libsystem_pthread.dylib] 21:07:17 9: 0x7fff72fe2b8b thread_start [/usr/lib/system/libsystem_pthread.dylib] 21:07:17 ... PR-URL: #35484 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [#35171](#35171) PR-URL: #35525

nodejs-github-bot · 2020-10-06T19:19:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33433/ ✅

danielleadams · 2020-10-06T19:20:15Z

V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3446/

danielleadams · 2020-10-06T19:42:15Z

CITGM: https://ci.nodejs.org/job/citgm-smoker/2500/

Trott · 2020-10-07T05:05:38Z

Should #35171 be semver-minor? (It's fine with me if the answer is "no", but it does seem a little surprising that it would be semver-patch.)

richardlau · 2020-10-07T11:42:47Z

Should #35171 be semver-minor? (It's fine with me if the answer is "no", but it does seem a little surprising that it would be semver-patch.)

I don't think we have a written policy for graduating an API from experimental (we do for new modules, but I can't see one for an individual API). This particular case doesn't actually change the API or change the printing of any warning messages so it is technically patch. In any case it's definitely notable.

BethGriggs · 2020-10-07T16:07:29Z

There were a bunch of CITGM failures on windows - https://ci.nodejs.org/job/citgm-smoker/2500/nodes=win-vs2017/testReport/

Rerunning against v14.13.0 to see if they were introduced in this proposal - https://ci.nodejs.org/job/citgm-smoker/2505/

richardlau · 2020-10-07T16:21:51Z

There were a bunch of CITGM failures on windows

See https://github.com/nodejs/Release/blob/master/doc/meetings/2020-09-24.md#qa-other. We previously weren't aware of CITGM results on Windows as CITGM was broken (now fixed).

BethGriggs · 2020-10-07T16:47:42Z

See https://github.com/nodejs/Release/blob/master/doc/meetings/2020-09-24.md#qa-other. We previously weren't aware of CITGM results on Windows as CITGM was broken (now fixed).

I recall, having PR'd the minutes. But I still think it is worth running a baseline on windows against v14.13.0 to help determine whether any of the failures are specific to v14.13.1.

BethGriggs · 2020-10-07T17:14:02Z

CI: ✅
V8 CI: Benchmarking not running due to nodejs/build#2451, others passed
CITGM: ✅, no new failures introduced in v14.13.1.

PR-URL: #35525

Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [#35171](#35171) PR-URL: #35525

Refs: nodejs/node#35525

Refs: nodejs#35525 PR-URL: nodejs#35782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Refs: #35525 PR-URL: #35782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [nodejs#35171](nodejs#35171) PR-URL: nodejs#35525

Trottand others added 30 commits October 6, 2020 08:19

esm: use "node:" namespace for builtins
91b820e
PR-URL: #35387 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

fs: use Promise.resolve from primordials
e4a4f81
PR-URL: #35379 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

doc: align to function signature
998b24e
PR-URL: #34930 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

doc: update example ICU URL
79e3e50
PR-URL: #35373 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

tools: exclude gyp from markdown link checker
a4e5a3a
The changelog format used in gyp-next does not comply to the rules. PR-URL: #35423 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]>

module: refine module type mismatch error cases
f23a0e2
PR-URL: #35426 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Myles Borins <[email protected]>

tools: check links in api docs
166f14a
Fixes: #35189 PR-URL: #35191 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>

doc: unhide resolver spec
d642788
PR-URL: #35358 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>

doc: implement fancier rendering for keys
86f2f83
Minimal CSS and markup changes to implement special rendering for `<kbd>` elements. PR-URL: #35400 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>

doc: importable node protocol URLs
35b62ef
PR-URL: #35434 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jan Krems <[email protected]>

crypto: set env values in KeyObject Deserialize method
1f15e34
Fixes: #35263 PR-URL: #35416 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>

2020-10-07, Version 14.13.1 (Current)
7c5f319
Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [#35171](#35171) PR-URL: #35525

danielleadams force-pushed the v14.13.1-proposal branch from 3906071 to 7c5f319Compare October 6, 2020 19:18

BethGriggs approved these changes Oct 7, 2020
View reviewed changes

danielleadams merged commit 7c5f319 into v14.xOct 7, 2020

danielleadams added a commit that referenced this pull request Oct 7, 2020
Working on v14.13.2
fca324e
PR-URL: #35525

danielleadams added a commit that referenced this pull request Oct 7, 2020
2020-10-07, Version 14.13.1 (Current)
d0438a6
Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [#35171](#35171) PR-URL: #35525

danielleadams pushed a commit to danielleadams/nodejs.org that referenced this pull request Oct 7, 2020
Blog: v14.13.1 release post
10eda8a
Refs: nodejs/node#35525

danielleadams mentioned this pull request Oct 7, 2020
Blog: v14.13.1 release post nodejs/nodejs.org#3439
Merged

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request Oct 7, 2020
Blog: v14.13.1 release post (#3439)
67c8682
Refs: nodejs/node#35525

danielleadams deleted the v14.13.1-proposal branch October 7, 2020 21:45

aduh95 mentioned this pull request Oct 23, 2020
doc: add missing link in Node.js 14 Changelog #35782
Merged
2 tasks

richardlau pushed a commit that referenced this pull request Oct 26, 2020
doc: add missing link in Node.js 14 Changelog
5b7a08c
Refs: #35525 PR-URL: #35782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

targos pushed a commit that referenced this pull request Nov 3, 2020
doc: add missing link in Node.js 14 Changelog
292b529
Refs: #35525 PR-URL: #35782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
2020-10-07, Version 14.13.1 (Current)
e8511bb
Notable changes: * fs: * remove experimental from rmdir recursive (Benjamin Coe) [nodejs#35171](nodejs#35171) PR-URL: nodejs#35525

targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

V14.13.1 proposal#35525

V14.13.1 proposal #35525

Uh oh!

danielleadams commented Oct 6, 2020•
edited
Loading

Uh oh!

nodejs-github-bot commented Oct 6, 2020•
edited by BethGriggs
Loading

Uh oh!

danielleadams commented Oct 6, 2020

Uh oh!

danielleadams commented Oct 6, 2020

Uh oh!

Trott commented Oct 7, 2020

Uh oh!

richardlau commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020

Uh oh!

richardlau commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

V14.13.1 proposal#35525

V14.13.1 proposal #35525

Uh oh!

Conversation

danielleadams commented Oct 6, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2020-10-07, Version 14.13.1 (Current), @BethGriggs prepared by @danielleadams

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Oct 6, 2020• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielleadams commented Oct 6, 2020

Uh oh!

danielleadams commented Oct 6, 2020

Uh oh!

Trott commented Oct 7, 2020

Uh oh!

richardlau commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020

Uh oh!

richardlau commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020

Uh oh!

BethGriggs commented Oct 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

danielleadams commented Oct 6, 2020•
edited
Loading

nodejs-github-bot commented Oct 6, 2020•
edited by BethGriggs
Loading

BethGriggs commented Oct 7, 2020•
edited
Loading