build: fix CQ after latest ncu release#35468
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta 
ContributorAuthor
mmarchini commented Oct 2, 2020
Fast track? |
The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit.
14 tasks
richardlau approved these changes Oct 2, 2020
BethGriggs approved these changes Oct 2, 2020
ContributorAuthor
mmarchini commented Oct 2, 2020
Landed in 919be91 |
mmarchini added a commit that referenced this pull request Oct 2, 2020
The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit. PR-URL: #35468 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit. PR-URL: #35468 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
The new behavior of node-core-utils (which fetches the merge commit instead of fetching the patch files) requires the whole repo to be cloned, instead of just the last commit. PR-URL: nodejs#35468 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes