Skip to content

tools: fix typo in error message#35417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aduh95 wants to merge 1 commit into from
Closed

tools: fix typo in error message #35417

aduh95 wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Sep 29, 2020

Currently on master:

Unordered reference at …/doc/api/packages.md:964:1 ("ES module" should be before "ES modules)"

With this PR:

Unordered reference at …/doc/api/packages.md:964:1 ("ES module" should be before "ES modules")
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 29, 2020
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33300/

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33365/

lpinca pushed a commit that referenced this pull request Oct 4, 2020
@aduh95@lpinca
tools: fix typo in error message
6467d1d
PR-URL: #35417 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@lpinca
Copy link
Member

lpinca commented Oct 4, 2020

Landed in 6467d1d.

@lpincalpinca closed this Oct 4, 2020
@danielleadamsdanielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@aduh95@danielleadams
tools: fix typo in error message
f499302
PR-URL: #35417 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95@joesepi
tools: fix typo in error message
7f59fe2
PR-URL: nodejs#35417 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@aduh95aduh95 deleted the fix-typo-checkLinks.js branch July 16, 2022 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@richardlaurichardlaurichardlau approved these changes

@himself65himself65himself65 approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@nodejs-github-bot@lpinca@Trott@richardlau@himself65@addaleax