doc: add entry to console.timeEnd() changes array#35441
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added console 4 tasks
Trott approved these changes Oct 1, 2020
cjihrig approved these changes Oct 1, 2020
puzpuzpuz approved these changes Oct 1, 2020
jasnell approved these changes Oct 1, 2020
Member
jasnell commented Oct 1, 2020
This shouldn't need to wait to land. Fast-track? |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 1, 2020
gireeshpunathil approved these changes Oct 2, 2020
Collaborator
nodejs-github-bot commented Oct 3, 2020
trivikr approved these changes Oct 4, 2020
PR-URL: nodejs#35441 Refs: nodejs#35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
lpincaforce-pushed the add/entry-for-console-timeend-changes branch from 5a6c5d4 to fa53a65CompareMemberAuthor
lpinca commented Oct 4, 2020
Landed in fa53a65. |
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #35441 Refs: #35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35441 Refs: nodejs#35027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #35027
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes