module: update to [email protected]#35501
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos approved these changes Oct 4, 2020
Member
targos left a comment
targos left a comment There was a problem hiding this comment.
LGTM with an update of the link in doc/api/esm.md
shisama approved these changes Oct 4, 2020
Collaborator
nodejs-github-bot commented Oct 4, 2020
jasnell approved these changes Oct 4, 2020
MylesBorins approved these changes Oct 5, 2020
Contributor
MylesBorins left a comment
MylesBorins left a comment There was a problem hiding this comment.
RSLGTM
Would good to have this land tomorrow so it can go out in 14 to get picked up in 12
Contributor
MylesBorins commented Oct 5, 2020
fast track? |
MylesBorins added esm 4 tasks
ContributorAuthor
guybedford commented Oct 5, 2020
Happy to fast track, but there isn't too much of a rush on this since it is mostly edge cases and perf so a patch would be fine too. Still nice to get it in though. |
Trott approved these changes Oct 5, 2020
ContributorAuthor
guybedford commented Oct 5, 2020
@Trott would you be ok with the fast track here as well? |
Contributor
MylesBorins commented Oct 5, 2020
Landed in db4b0ec |
MylesBorins pushed a commit that referenced this pull request Oct 5, 2020
PR-URL: #35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
4 tasks
7 tasks
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 23, 2020
PR-URL: nodejs#35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
3 tasks
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
Backport-PR-URL: #35757 PR-URL: #35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
Backport-PR-URL: #35757 PR-URL: #35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35501 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to [email protected] containing the following two improvements:
module.exports = require('external')case, which should avoid unnecessary work for webpack bundle externals also as a minor performance improvement (Only include last reexport assignment cjs-module-lexer#11)@nodejs/modules-active-members
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes