process: reintroduce ares to versions#347
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ares version info was accidentally removed in c80f8fa.
Member
indutny commented Jan 14, 2015
@jbergstroem what do you think about adding a test, so it won't slip away again? |
Member
indutny commented Jan 14, 2015
@rvagg this is the blocker too |
MemberAuthor
jbergstroem commented Jan 14, 2015
@indutny sure. couldn't find any other process.version tests; should we introduce that in a new PR? |
Member
indutny commented Jan 14, 2015
Makes sense. |
Member
indutny commented Jan 14, 2015
LGTM |
indutny pushed a commit that referenced this pull request Jan 14, 2015
ares version info was accidentally removed in c80f8fa. PR-URL: #347 Reviewed-By: Fedor Indutny <[email protected]>
Member
indutny commented Jan 14, 2015
Landed in 01736dd, thank you! |
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Oct 19, 2016
ares version info was accidentally removed in c80f8fa. PR-URL: nodejs#347 Reviewed-By: Fedor Indutny <[email protected]>
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ares version info was accidentally removed in c80f8fa.
/cc @indutny