process: reintroduce ares to versions

[richardlau]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

process

Description of change

process.versions.ares is missing in v0.12.17 (and earlier v0.12.x):

-bash-4.2$ ./node > process.versions{http_parser: '2.3', node: '0.12.17', v8: '3.28.71.19', uv: '1.6.1', zlib: '1.2.8', modules: '14', openssl: '1.0.1u' } > .exit -bash-4.2$ 

Fixed by cherry-picking 01736dd (reference #347)

[richardlau]

Since I cherry-picked, the commit has the original commit message. Let me know if I should reword it.

cc @jbergstroem (since it was originally your fix 😄 )

[cjihrig]

Does this qualify as a change that should go into a maintenance branch?

[richardlau]

Good question. It's there in v0.10.x, v4.x and later -- Just missing in v0.12.x. I'm guessing it doesn't affect anyone enough to have raised an issue about it.

[MylesBorins]

we can out it in staging and include it in a future release if we need to
do one

On Wed, Oct 19, 2016, 9:22 PM Richard Lau [email protected] wrote:

Good question. It's there in v0.10.x, v4.x and later -- Just missing in
v0.12.x. I'm guessing it doesn't affect anyone enough to have raised an
issue about it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9191 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV9M-GaL25B3vZ9EeNLRpAPs83aklks5q1nwCgaJpZM4KbYRN
.

[Fishrock123]

Is this actually important to anyone?

[jbergstroem]

@Fishrock123 consistency, perhaps.

[gibfahn]

Change LGTM, no strong opinions on whether it needs to be added back in.

Is there any downside to including it in the next v0.12 release?

[jasnell]

Landed in v0.12-staging with 0cdf344