doc: add ESM examples in module API doc page#34875
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
aduh95 commented Aug 22, 2020
Uh oh!
There was an error while loading. Please reload this page.
aduh95 commented Aug 24, 2020
Uh oh!
There was an error while loading. Please reload this page.
2 tasks
Contributor
MylesBorins commented Sep 1, 2020
/cc @nodejs/modules |
guybedford approved these changes Sep 1, 2020
Contributor
DerekNonGeneric commented Sep 6, 2020
Landed in b0cc657 |
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 4, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#34875 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to promote ESM usage, add examples using this syntax alongside CJS ones. I've also added some links where it was missing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes