meta: update module pages in CODEOWNERS#34932
Conversation
Review requested:
|
nodejs-github-bot added the meta 
richardlau commented Aug 26, 2020
This will be blocked until that lands as the linting for CODEOWNERS will fail for non-existent paths. |
Uh oh!
There was an error while loading. Please reload this page.
mmarchini commented Aug 26, 2020
This is a good idea once we have all files listed (we're still very far today) |
aduh95 commented Aug 29, 2020
@richardlau#34748 has landed, is there something I can do to unblock this PR? |
richardlau commented Aug 29, 2020
Rebase so that it’s picked up — that should get the lint-codeowners check to pass. |
MylesBorins commented Aug 31, 2020
Landed in 622ea75 |
PR-URL: #34932 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
aduh95 commented Sep 1, 2020
#34875 is not getting much love because @nodejs-github-bot didn't know who to tag. Can someone ping @nodejs/modules over there please? |
richardlau commented Sep 1, 2020
This depends on #34748 (otherwise the CODEOWNER linting breaks) and that has the |
PR-URL: #34932 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #34932 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
7 participants
I figured that should explain why the bot didn't tag @nodejs/modules in #34875.
Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?
I've also added
/doc/api/packages.md, which will be introduced by #34748, it's probably a good idea to wait for it to land first before landing this PR.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes