Skip to content

Conversation

@Trott
Copy link
Member

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Oct 18, 2020
@Trott
Copy link
MemberAuthor

Before:

image

After:

image

@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #35698 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #35698 +/- ## ======================================= Coverage 96.40% 96.40% ======================================= Files 220 220 Lines 73681 73681 ======================================= + Hits 71031 71032 +1 + Misses 2650 2649 -1 
Impacted FilesCoverage Δ
lib/_http_server.js98.45% <0.00%> (+0.10%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe33aa...7b17c36. Read the comment docs.

PR-URL: nodejs#35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
MemberAuthor

Landed in 6c4239b

@TrottTrott merged commit 6c4239b into nodejs:masterOct 21, 2020
@TrottTrott deleted the readline-kbd branch October 21, 2020 11:46
BethGriggs pushed a commit that referenced this pull request Oct 21, 2020
PR-URL: #35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 21, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@codecov-io@lpinca@watilde@nodejs-github-bot