Skip to content

Conversation

@BethGriggs
Copy link
Member

@BethGriggsBethGriggs commented Dec 10, 2020

Initially proposing Tuesday 15th December - this is shorter than our normal proposal period for LTS, but there are a handful of regressions I think we should patch prior to the holidays. Could potentially delay to Thursday 17th to allow an extra couple of days notice.


2020-12-15, Version 14.15.2 'Fermium' (LTS), @BethGriggs

Notable Changes

  • deps:
    • upgrade npm to 6.14.9 (Myles Borins) #36450
    • update acorn to v8.0.4 (Michaël Zasso) #35791
  • doc: add release key for Danielle Adams (Danielle Adams) #35545
  • http2: check write not scheduled in scope destructor (David Halls) #36241
  • stream: fix regression on duplex end (Momtchil Momtchev) #35941

Commits

mhdawsonand others added 21 commits November 16, 2020 16:39
Fixes: #35620 This reverts commit a6b6556 which changed finalization behavior related to N-API. We will investigate the original issue with the test separately. PR-URL: #35777 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
PR-URL: #35745 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #35871 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #35901 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Signed-off-by: Hussaina Begum Nandyala <[email protected]> PR-URL: #35618 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: #35588 PR-URL: #35595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Move all the streams constructors to internal/streams and avoid a circular dependencies between the modules. See: nodejs/readable-stream#348 PR-URL: #35239 Backport-PR-URL: #35349 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
The feature was added in Node.js v15.0.0. Fixes: #36058 PR-URL: #36119 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: #35635 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
PR-URL: #35613 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #35625 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by: James M Snell <[email protected]> PR-URL: #35616 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
It is already installed in the GitHub runners. PR-URL: #35638 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
The other way is deprecated. PR-URL: #35638 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #35642 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter. PR-URL: #33513 Reviewed-By: James M Snell <[email protected]>
PR-URL: #35086 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions PR-URL: #32805 Reviewed-By: James M Snell <[email protected]>
PR-URL: #35690 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v14.x labels Dec 10, 2020
@BethGriggsBethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2020

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2020

Trottand others added 7 commits December 15, 2020 20:15
Update comment to refer to the correct ASCII code (120 rather than 66). All other changes are cosmetic. PR-URL: #36152 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #36163 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
alredy -> already PR-URL: #36193 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Pranshu Srivastava <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
PR-URL: #36175 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #36450 Fixes: https://github.com/docs Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36372 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Notable Changes: - **deps**: - upgrade npm to 6.14.9 (Myles Borins) #36450 - update acorn to v8.0.4 (Michaël Zasso) #35791 - **doc**: add release key for Danielle Adams (Danielle Adams) #35545 - **http2**: check write not scheduled in scope destructor (David Halls) #36241 - **stream**: fix regression on duplex end (Momtchil Momtchev) #35941 PR-URL: #36476
@BethGriggsBethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2020

@BethGriggs
Copy link
MemberAuthor

As i've hit a few flaky runs, for now i've opted to back out the following commits related to the introduction of the linux-coverage action:

  • build: add GitHub Action for code coverage (Benjamin Coe) #35653
  • test: add windows and C++ coverage (Benjamin Coe) #35670
  • test: refactor coverage logic (Benjamin Coe) #35767
  • build: turn off Codecov comments (Benjamin Coe) #35800
  • doc: fix typo in BUILDING.md (raisinten) #35807

@BethGriggs
Copy link
MemberAuthor

Release build on a2f9a70: https://ci-release.nodejs.org/job/iojs+release/6531
Release build on a2f9a70 (osx rebuild): https://ci-release.nodejs.org/job/iojs+release/6532

@BethGriggsBethGriggs merged commit a2f9a70 into v14.xDec 15, 2020
BethGriggs added a commit that referenced this pull request Dec 15, 2020
BethGriggs added a commit that referenced this pull request Dec 15, 2020
Notable Changes: - **deps**: - upgrade npm to 6.14.9 (Myles Borins) #36450 - update acorn to v8.0.4 (Michaël Zasso) #35791 - **doc**: add release key for Danielle Adams (Danielle Adams) #35545 - **http2**: check write not scheduled in scope destructor (David Halls) #36241 - **stream**: fix regression on duplex end (Momtchil Momtchev) #35941 PR-URL: #36476
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Dec 15, 2020
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Dec 16, 2020
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Dec 16, 2020
@BethGriggsBethGriggs deleted the v14.15.2-proposal branch December 17, 2020 19:04
@vecerek
Copy link

@BethGriggs is 6cea3152fe going to be ported over to v12 as well?

@BethGriggs
Copy link
MemberAuthor

@vecerek, we bundled the npm updates (6.14.9 and 6.14.10) into the v12.20.1 security release today - https://nodejs.org/en/blog/release/v12.20.1/

@targostargos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jun 6, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releaseIssues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@BethGriggs@nodejs-github-bot@richardlau@vecerek@MylesBorins@targos@mhdawson@guybedford@hexxdump@gireeshpunathil@mcollina@lpinca@ryzokuken@rvagg@Trott@PoojaDurgad@jasnell@shaw91@tniessen@himself65