Skip to content

doc,test: update v8 method doc and comment#35795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Oct 27, 2020
Merged

doc,test: update v8 method doc and comment #35795

Trott merged 1 commit into from
Oct 27, 2020

Conversation

@Trott
Copy link
Member

@TrottTrott commented Oct 25, 2020

Update documentation and test comment for v8.cachedDataVersionTag().

Checklist

@TrottTrottforce-pushed the cachedDataVersionTag branch 2 times, most recently from 9859b08 to ad97155CompareOctober 25, 2020 12:59
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. v8 module Issues and PRs related to the "v8" subsystem. labels Oct 25, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33856/

@codecov-io
Copy link

codecov-io commented Oct 25, 2020•
edited
Loading

Codecov Report

Merging #35795 into master will decrease coverage by 8.51%.
The diff coverage is 81.34%.

@@ Coverage Diff @@## master #35795 +/- ## ========================================== - Coverage 96.40% 87.89% -8.52%  ========================================== Files 223 477 +254 Lines 73685 113172 +39487 Branches 0 25426 +25426 ========================================== + Hits 71038 99473 +28435 - Misses 2647 7996 +5349 - Partials 0 5703 +5703
Impacted FilesCoverage Δ
src/node_http2.h92.06% <ø> (ø)
src/node_report.cc90.71% <ø> (ø)
src/inspector_profiler.cc76.17% <69.44%> (ø)
lib/internal/dns/utils.js98.44% <75.00%> (-1.56%)⬇️
src/cares_wrap.cc63.42% <77.77%> (ø)
src/node_http2.cc83.76% <81.25%> (ø)
lib/internal/dns/promises.js100.00% <100.00%> (ø)
lib/internal/http2/core.js94.97% <100.00%> (-1.98%)⬇️
lib/internal/streams/destroy.js94.66% <100.00%> (-2.19%)⬇️
lib/internal/streams/from.js98.01% <100.00%> (ø)
... and 399 more

lpinca
lpinca approved these changes Oct 25, 2020
View reviewed changes
@TrottTrottforce-pushed the cachedDataVersionTag branch from ad97155 to 641ef5aCompareOctober 26, 2020 04:29
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2020•
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33867/ ✅

@Trott
doc,test: update v8 method doc and comment
245ec6f
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: nodejs#35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@TrottTrottforce-pushed the cachedDataVersionTag branch from 641ef5a to 245ec6fCompareOctober 27, 2020 13:19
@Trott
Copy link
MemberAuthor

Trott commented Oct 27, 2020

Landed in 245ec6f

@TrottTrott merged commit 245ec6f into nodejs:masterOct 27, 2020
@TrottTrott deleted the cachedDataVersionTag branch October 27, 2020 13:20
targos pushed a commit that referenced this pull request Nov 3, 2020
@Trott@targos
doc,test: update v8 method doc and comment
092c6c4
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@targostargos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@Trott@BethGriggs
doc,test: update v8 method doc and comment
3e99e3e
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott@BethGriggs
doc,test: update v8 method doc and comment
000c514
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott@BethGriggs
doc,test: update v8 method doc and comment
be79250
Update documentation and test comment for v8.cachedDataVersionTag(). PR-URL: #35795 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+1 more reviewer

@watildewatildewatilde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 moduleIssues and PRs related to the "v8" subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@codecov-io@lpinca@watilde@gireeshpunathil