Skip to content

build: replace which with command -v#36118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RaisinTen wants to merge 1 commit into from
Closed

build: replace which with command -v #36118

RaisinTen wants to merge 1 commit into from

Conversation

@RaisinTen
Copy link
Member

@RaisinTenRaisinTen commented Nov 14, 2020•
edited
Loading

I read here that it is better to avoid which and use command -v instead: https://stackoverflow.com/a/677212

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 14, 2020
@RaisinTenRaisinTen marked this pull request as ready for review November 14, 2020 16:29
richardlau
richardlau reviewed Nov 14, 2020
View reviewed changes
@aduh95aduh95 mentioned this pull request Nov 14, 2020
Closed
8 tasks
@RaisinTenRaisinTenforce-pushed the refactor/replace-which-with-command-v branch from 350c92c to cc3c31eCompareNovember 15, 2020 12:10
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 16, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34428/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2020
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@aduh95aduh95 mentioned this pull request Nov 19, 2020
Open
14 tasks
@aduh95
Copy link
Contributor

aduh95 commented Nov 19, 2020

Landed in 2d167f0

@aduh95aduh95 closed this Nov 19, 2020
aduh95 pushed a commit that referenced this pull request Nov 19, 2020
@RaisinTen@aduh95
build: replace which with command -v
2d167f0
PR-URL: #36118 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen@codebytere
build: replace which with command -v
fcc38a1
PR-URL: #36118 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen@BethGriggs
build: replace which with command -v
50a599d
PR-URL: #36118 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen@BethGriggs
build: replace which with command -v
bce29c0
PR-URL: #36118 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen@BethGriggs
build: replace which with command -v
699bb34
PR-URL: #36118 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@RaisinTenRaisinTen deleted the refactor/replace-which-with-command-v branch December 16, 2020 15:20
@kurahaupo
Copy link

kurahaupo commented Jan 2, 2023

The very same StackOverflow article notes that the correct way to check whether a command exists is to use the exit status of command, so [ `which thing` ] should be transformed to command -v thing 2>/dev/null and not[ `command -v thing` ].

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments

@TrottTrottTrott approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RaisinTen@nodejs-github-bot@aduh95@kurahaupo@Trott@joyeecheung@richardlau