Skip to content

Conversation

@PoojaDurgad
Copy link
Contributor

example code added to the process.setgroups() API
doc property in process.md

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

example code added to the process.setgroups() API doc property in process.md
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #35738 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #35738 +/- ## ======================================= Coverage 96.40% 96.40% ======================================= Files 220 223 +3 Lines 73675 73685 +10 ======================================= + Hits 71025 71035 +10  Misses 2650 2650 
Impacted FilesCoverage Δ
lib/net.js95.28% <0.00%> (-0.02%)⬇️
lib/path/win32.js100.00% <0.00%> (ø)
lib/path/posix.js100.00% <0.00%> (ø)
lib/util/types.js100.00% <0.00%> (ø)
lib/internal/modules/esm/translators.js95.21% <0.00%> (+0.06%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b18651b...1fa3776. Read the comment docs.

@Trott
Copy link
Member

I notice that L2207 indicates the array can only contain integers, but the text on L2213 correctly says it can also contain strings (group names). Might be good to update L2207. I'm not sure how to specify "an array of integers and/or strings" but {integer[]|string[]} might be close enough. (To me, that says "an array of integers or an array of strings" but excludes "an array that contains both". Still, that's better than not mentioning strings at all.)

@gireeshpunathilgireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2020
aduh95 pushed a commit that referenced this pull request Oct 25, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@aduh95
Copy link
Contributor

Landed in fc3f41b

@aduh95aduh95 closed this Oct 25, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@targostargos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@PoojaDurgad@codecov-io@Trott@aduh95@lpinca@gireeshpunathil@nodejs-github-bot