test: replace var statements by let statements#36069
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Trott commented Nov 10, 2020
Seems to me these could be |
ContributorAuthor
arsenalzp commented Nov 10, 2020
|
benjamingr approved these changes Nov 10, 2020
watilde approved these changes Nov 11, 2020
Trott reviewed Nov 11, 2020
lib/internal/streams/pipeline.js Outdated
Trott approved these changes Nov 11, 2020
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 11, 2020
Member
Might you be using |
Member
Trott commented Nov 12, 2020
Rebased and squashed. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 12, 2020
gireeshpunathil approved these changes Nov 12, 2020
gireeshpunathil added the commit-queue github-actionsbot added commit-queue-failed 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36069 ✔ Done loading data for nodejs/node/pull/36069 ----------------------------------- PR info ------------------------------------ Title test: replace var statements by let statements (#36069) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch arsenalzp:my-branch -> nodejs:master Labels test Commits 1 - test: replace var with const Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/36069 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Daijiro Wachi Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36069 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Daijiro Wachi Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-12T02:19:31Z: https://ci.nodejs.org/job/node-test-pull-request/34355/ - Querying data for job/node-test-pull-request/34355/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Tue, 10 Nov 2020 16:52:48 GMT ✔ Approvals: 4 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36069#pullrequestreview-527551478 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/36069#pullrequestreview-527721413 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36069#pullrequestreview-528226897 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/36069#pullrequestreview-528741408 ✖ This PR needs to wait 12 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuCommit Queue action: https://github.com/nodejs/node/actions/runs/359025849 |
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: nodejs#36069 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Member
Trott commented Nov 13, 2020
Landed in e4507e5 |
codebytere pushed a commit that referenced this pull request Nov 22, 2020
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: #36069 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: #36069 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: #36069 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: #36069 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos removed the commit-queue-failed Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes