deps: upgrade to [email protected]#35928
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Nov 2, 2020
Review requested:
|
nodejs-github-bot added the lib / src 
ContributorAuthor
guybedford commented Nov 2, 2020
Requesting a fast track here again. |
MylesBorins added the fast-track 
Contributor
MylesBorins commented Nov 2, 2020
Can we please fast track? |
bmeck approved these changes Nov 2, 2020
targos approved these changes Nov 2, 2020
Member
targos left a comment
targos left a comment There was a problem hiding this comment.
LGTM with an update of the link in the docs
Collaborator
nodejs-github-bot commented Nov 2, 2020
ContributorAuthor
guybedford commented Nov 2, 2020
Landed in a5f99b8. |
guybedford added a commit that referenced this pull request Nov 2, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to [email protected], with some final getter refinements to fix#35859.
To explain the getter handling story here:
Object.definePropertyonce called to set a value property, which was then being detected as one of these safe properties.Thus this update includes the fix at nodejs/cjs-module-lexer#29 which adds unsafe getter tracking to specifically mark unsafe getters and never emit them even if they later have safe getter forms.
I've verified this fixes the test case from #35859.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes