win,build,tools: support VS prerelease#36033
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
Member
targos commented Nov 8, 2020
@nodejs/platform-windows |
Member
Trott commented Nov 11, 2020
@nodejs/build-files |
Member
Trott commented Nov 14, 2020
@nodejs/build |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 17, 2020
Collaborator
nodejs-github-bot commented Nov 17, 2020
Trott approved these changes Nov 19, 2020
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Much more comfortable giving this a 👍 now that there's approval from an actual Windows user/expert.
jasnell approved these changes Nov 19, 2020
richardlau added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 6312193...80a83d9 |
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2020
PR-URL: #36033 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Trott commented Nov 21, 2020
Thanks for the contribution! 🎉 |
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36033 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #36033 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #36033 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #36033 Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesI don't know if we supporting
prerelease(Preview) versions, but I see there is a flow for that, so I just adjust it.Without my change, I have both Visual Studio 19 Preview and Visual Studio 17 Enterprise, but I getting the next error: