test: turn off coverage comments#35800
Merged
+8 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
bcoe commented Oct 25, 2020
@thomasrockhu, we're still getting value out of the reports 👏 (for instance, see #35797 (comment)), but quite a few folks have been confused by reported drops in coverage, not related to their PRs. An ideaRather than providing information about drops in coverage as a comment, it would be useful to simply link to the coverage report for a |
watilde approved these changes Oct 25, 2020
Qard approved these changes Oct 25, 2020
This comment has been minimized.
This comment has been minimized.
bcoe added author ready ContributorAuthor
bcoe commented Oct 25, 2020
watilde approved these changes Oct 26, 2020
Collaborator
nodejs-github-bot commented Oct 26, 2020
Trott approved these changes Oct 26, 2020
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: nodejs#35800 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Oct 26, 2020
Landed in 4ace92f |
targos pushed a commit that referenced this pull request Nov 3, 2020
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: #35800 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: #35800 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Turns off coverage comments for the time being, until we can sort out issues. PR-URL: #35800 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos added dont-land-on-v14.x and removed author ready Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns off coverage comments for the time being, until we can sort out #35759
Refs #35759, #35779, #35753
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes