Skip to content

benchmark: fix build warnings#36157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabrielschulhof wants to merge 1 commit into from
Closed

benchmark: fix build warnings #36157

gabrielschulhof wants to merge 1 commit into from

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhofgabrielschulhof commented Nov 18, 2020

The napi/* benchmarks were using an incorrect signature for the V8
add-on init function. This was causing a warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

benchmark: fix build warnings
abad981
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]>
@nodejs-github-botnodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Nov 18, 2020
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2020
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34451/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 18, 2020•
edited by gabrielschulhof
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34453/ ✔️

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2020
gabrielschulhof pushed a commit that referenced this pull request Nov 20, 2020
benchmark: fix build warnings
39e4d82
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@gabrielschulhof
Copy link
ContributorAuthor

gabrielschulhof commented Nov 20, 2020

Landed in 39e4d82.

@gabrielschulhofgabrielschulhof deleted the fix-function-call-bench-warning branch November 20, 2020 04:30
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@codebytere
benchmark: fix build warnings
3ee556a
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@codebyterecodebytere mentioned this pull request Nov 22, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@BethGriggs
benchmark: fix build warnings
db06543
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@BethGriggs
benchmark: fix build warnings
b1a1834
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@BethGriggs
benchmark: fix build warnings
d49e0ca
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof@nodejs-github-bot@jasnell@Trott@lpinca@richardlau