doc: fix typo in BUILDING.md#35807
Closed
doc: fix typo in BUILDING.md #35807
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
richardlau approved these changes Oct 26, 2020
watilde approved these changes Oct 26, 2020
Trott approved these changes Oct 26, 2020
gengjiawen approved these changes Oct 26, 2020
aduh95 added the author ready 
aduh95 approved these changes Oct 26, 2020
gireeshpunathil approved these changes Oct 26, 2020
MemberAuthor
RaisinTen commented Oct 26, 2020
How may I fix this? |
Contributor
watilde commented Oct 26, 2020
As this PR fixes a typo, let me ask for 👍 to fast track. @RaisinTen Basically we need to wait for 48h before we ship or get more than two 👍 from collaborators on this comment to quickly ship. Refs: https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#waiting-for-approvals |
Contributor
aduh95 commented Oct 26, 2020
@RaisinTen If you refer to the failing GitHub Action, don't worry it's just a flaky CI job that timed out. I've restarted the job, it should be fine now. |
MemberAuthor
RaisinTen commented Oct 26, 2020
juanarbol approved these changes Oct 26, 2020
Member
juanarbol left a comment
juanarbol left a comment There was a problem hiding this comment.
@RaisinTen Thanks for your contribution. This is awesome!
lpinca approved these changes Oct 26, 2020
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 26, 2020
Member
juanarbol commented Oct 26, 2020
@lpinca This is a doc-only change, this does not require a full CI-job, with green actions is enough. I think this can be landed as it is now (?). |
watilde added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 9ff25b1...ed5e539 |
nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
targos pushed a commit that referenced this pull request Mar 3, 2021
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
PR-URL: #35807 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist