tools: remove bashisms from license builder script#36122
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott approved these changes Nov 16, 2020
aduh95 added author ready 
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Nov 17, 2020
richardlau approved these changes Nov 17, 2020
aduh95 added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 665da27...ed26808 |
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2020
PR-URL: #36122 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36122 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #36122 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #36122 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #36122 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #36099
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes