Skip to content

assert,repl: enable ecmaVersion 2021 in acorn parser#35827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 2 commits into from
Closed

assert,repl: enable ecmaVersion 2021 in acorn parser #35827

targos wants to merge 2 commits into from

Conversation

@targos
Copy link
Member

@targostargos commented Oct 27, 2020

This adds support for the new logical assignment operators.

@targos
assert,repl: enable ecmaVersion 2021 in acorn parser
a315740
This adds support for the new logical assignment operators.
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. repl Issues and PRs related to the REPL subsystem. labels Oct 27, 2020
@targos
Copy link
MemberAuthor

targos commented Oct 27, 2020

@jasnell

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33882/

Trott
Trott approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@TrottTrott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an assert or repl test using the logical assignment operators in a way that would break without the acorn update? (Non-blocking question.)

@targos
Copy link
MemberAuthor

targos commented Oct 27, 2020

Should we add an assert or repl test using the logical assignment operators in a way that would break without the acorn update? (Non-blocking question.)

I'm not sure that's worth the effort.

BridgeAR
BridgeAR reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@BridgeARBridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use latest instead to prevent future updates. This is a recent feature added to acorn (https://github.com/acornjs/acorn/tree/master/acorn#interface).

@richardlau
Copy link
Member

richardlau commented Oct 27, 2020

I suggest to use latest instead to prevent future updates. This is a recent feature added to acorn (https://github.com/acornjs/acorn/tree/master/acorn#interface).

Is that not going to cause maintenance issues when the code ends up in release lines?

@BridgeAR
Copy link
Member

BridgeAR commented Oct 27, 2020

Is that not going to cause maintenance issues when the code ends up in release lines?

I am not certain I fully understand the comment. AFAIK the suggestion should minimize the maintenance need due to always providing the latest features acorn supports. Thus, there should be no need for a PR like this one after upgrading acorn.

@richardlau
Copy link
Member

richardlau commented Oct 27, 2020

Is that not going to cause maintenance issues when the code ends up in release lines?

I am not certain I fully understand the comment. AFAIK the suggestion should minimize the maintenance need due to always providing the latest features acorn supports. Thus, there should be no need for a PR like this one after upgrading acorn.

I mean that, say, we cut Node.js 16 with it set to latest but at some point latest picks up new language features that are not supported by Node.js 16.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 27, 2020

I mean that, say, we cut Node.js 16 with it set to latest but at some point latest picks up new language features that are not supported by Node.js 16.

That should not be an issue: it would fail execution in the REPL and assert would not be able to execute the code in the first place if it would not be supported.

But it's actually very unlikely to even get to that: we'd have to update acorn without noticing it already supporting features that Node.js does not and that has never happened before as far as I can tell. Acorn only supports features that are stable and we'd have to lack behind on updating V8 quite a lot for it to happen.

@richardlau
Copy link
Member

richardlau commented Oct 27, 2020

But it's actually very unlikely to even get to that: we'd have to update acorn without noticing it already supporting features that Node.js does not and that has never happened before as far as I can tell. Acorn only supports features that are stable and we'd have to lack behind on updating V8 quite a lot for it to happen.

¯\_(ツ)_/¯ I'm going off #35791 (comment) which implied that this PR shouldn't be backported to Node.js 14.

@targostargos added request-ci Add this label to start a Jenkins CI on a PR. and removed dont-land-on-v14.x labels Oct 28, 2020
@targos
Copy link
MemberAuthor

targos commented Oct 28, 2020

@BridgeAR convinced me that it should not be an issue if Acorn supports more syntax than V8.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33904/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33960/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33964/

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2020
@github-actions
Copy link
Contributor

github-actionsbot commented Oct 30, 2020

Landed in 87a6b60...0ddd69e

nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2020
@targos@nodejs-github-bot
assert,repl: enable ecmaVersion 2021 in acorn parser
0ddd69e
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@targostargos deleted the acorn-21 branch October 30, 2020 14:56
targos added a commit that referenced this pull request Nov 3, 2020
@targos
assert,repl: enable ecmaVersion 2021 in acorn parser
d95013f
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@targostargos mentioned this pull request Nov 3, 2020
Merged
@aduh95aduh95 mentioned this pull request Nov 6, 2020
Closed
2 tasks
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@targos@BethGriggs
assert,repl: enable ecmaVersion 2021 in acorn parser
eb1cdcd
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@targos@BethGriggs
assert,repl: enable ecmaVersion 2021 in acorn parser
dca3f27
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@targos@BethGriggs
assert,repl: enable ecmaVersion 2021 in acorn parser
a9d3a0d
This adds support for the new logical assignment operators. PR-URL: #35827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gengjiawengengjiawengengjiawen approved these changes

@richardlaurichardlaurichardlau approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@antsmartianantsmartianantsmartian approved these changes

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@targos@nodejs-github-bot@richardlau@BridgeAR@jasnell@Trott@antsmartian@cjihrig@gengjiawen@devsnek