Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
child_process: refactor to use more primordials#36269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
085d730 to d1e3196Compare
aduh95 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please remove the unrelated changes, and I've also let a comment on an optimisation we can make.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d1e3196 to 95ece51Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95 commented Nov 27, 2020
The benchmark suite is crashing before completion, I've opened #36295 to fix that. |
aduh95 commented Dec 2, 2020
aduh95 commented Dec 2, 2020
Benchmark results: Details |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot commented Dec 3, 2020 • edited by aduh95
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by aduh95
Uh oh!
There was an error while loading. Please reload this page.
Landed in a897a25...f7dd330 |
PR-URL: #36269 Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #36269 Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#36269 Reviewed-By: Antoine du Hamel <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes