benchmark,child_process: remove failing benchmark parameter#36295
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
A 16 MiB strings seems to be too large to be send to the parent process, making the whole benchmark throws.
nodejs-github-bot added benchmark 2 tasks
Trott approved these changes Nov 29, 2020
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Nov 30, 2020
Collaborator
lpinca approved these changes Dec 2, 2020
aduh95 added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 187a862...99f6167 |
nodejs-github-bot pushed a commit that referenced this pull request Dec 2, 2020
A 16 MiB strings seems to be too large to be send to the parent process, making the whole benchmark throws. PR-URL: #36295 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
A 16 MiB strings seems to be too large to be send to the parent process, making the whole benchmark throws. PR-URL: #36295 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
A 16 MiB strings seems to be too large to be send to the parent process, making the whole benchmark throws. PR-URL: nodejs#36295 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
A 16 MiB strings seems to be too large to be send to the parent process, making the whole benchmark throws. PR-URL: #36295 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 16 MiB strings seems to be too large to be send to the parent process,
making the whole benchmark throws.
See https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/717/console
Trial and error taught me that
65536 << 6 - 1is the largest values acceptable to not make the benchmark throw. That's maybe a bug we want to fix, but until someone sends a fix, this PR allowschild_processbenchmark suite to be run to completion.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes