[Backport v15.x] http: remove dead code from internal/http.js#36890
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
danielleadams approved these changes Jan 12, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Jan 12, 2021
Contributor
danielleadams commented Jan 12, 2021
A regression was introduced to the |
ContributorAuthor
aduh95 commented Jan 12, 2021
#36900 has landed, if you need to force push to my branch to rebase or what not, it's totally fine with me :) |
Contributor
danielleadams commented Jan 12, 2021
@aduh95 great! thanks |
Contributor
danielleadams commented Jan 13, 2021
@aduh95 I can't push up because it's a fork, so do you mind rebasing |
This reverts commit 9156f43.
PR-URL: nodejs#36630 Refs: nodejs#32329 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95force-pushed the backport-v15-36630 branch from 57782b0 to bae71f0CompareContributorAuthor
aduh95 commented Jan 13, 2021
Done! FYI, you can actually push to my branch if you specify my fork repo URL: |
Collaborator
nodejs-github-bot commented Jan 13, 2021
Contributor
danielleadams commented Jan 13, 2021
@aduh95 good to know. thanks! |
danielleadams approved these changes Jan 13, 2021
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
This reverts commit 9156f43. PR-URL: #36890 Refs: #32329 Reviewed-By: Danielle Adams <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
PR-URL: #36630 Backport-PR-URL: #36890 Refs: #32329 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Contributor
danielleadams commented Jan 13, 2021
Landed in d858c95 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix linter error in https://github.com/nodejs/node/pull/36889/checks?check_run_id=1688515238
/cc @danielleadams
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Rich Trott [email protected]