test: disable test-crypto-secure-heap with asan#36900
Merged
+3 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added fast-track 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 12, 2021
danielleadams approved these changes Jan 12, 2021
Merged
richardlau approved these changes Jan 12, 2021
aduh95 approved these changes Jan 12, 2021
Contributor
aduh95 commented Jan 12, 2021
fast-track? |
lpinca approved these changes Jan 12, 2021
Collaborator
nodejs-github-bot commented Jan 12, 2021
panva approved these changes Jan 12, 2021
MemberAuthor
jasnell commented Jan 12, 2021
Just waiting on the last CI run to finish then will land this... |
MemberAuthor
jasnell commented Jan 12, 2021
Landed in eef75a957c38 |
Contributor
aduh95 commented Jan 12, 2021
There is no commit eef75a957c38 on master.. |
The asan checks don't play well currently with persistent secure heap allocations. Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#36900 Refs: nodejs#36881 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
aduh95force-pushed the disable-secure-heap-test-for-asan branch from 3460b40 to 6e3a832CompareContributor
aduh95 commented Jan 12, 2021
Landed in 6e3a832 |
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
The asan checks don't play well currently with persistent secure heap allocations. Signed-off-by: James M Snell <[email protected]> PR-URL: #36900 Refs: #36881 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Member
addaleax commented Jan 16, 2021
Okay, but shouldn't there be at least a TODO comment for actually fixing this memory leak? It doesn't look like there's a call to |
MemberAuthor
jasnell commented Jan 17, 2021
Forgot the todo but adding the |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The asan checks don't play well currently with persistent secure
heap allocations.
Signed-off-by: James M Snell [email protected]
Refs: #36881