Skip to content

Conversation

@aduh95
Copy link
Contributor

TLA allows us to use more concise example and get rid of IIFE async functions.

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 26, 2021
@aduh95aduh95 added the doc Issues and PRs related to the documentations. label Jan 26, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

This would change the examples to be ones that cannot be placed in a .js file (let's say index.js) and run as node index.js. To me, that's a pretty big change and one we'd want to sort out across the docs. But maybe I'm wrong. @nodejs/documentation

@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2021
@aduh95
Copy link
ContributorAuthor

Removed author ready label to try to get more opinions before landing. I've also opened #37162 to address the more general issue.

@aduh95aduh95 added review wanted PRs that need reviews. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 4, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

Landed in 2be512d

@jasnelljasnell closed this Mar 5, 2021
@aduh95aduh95 deleted the vm-doc-tla branch March 5, 2021 18:14
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.review wantedPRs that need reviews.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@Trott@jasnell@lpinca@ExE-Boss@aymen94@RaisinTen