Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.3k
tools,doc: add support for several flavors of JS code snippets#37162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
aduh95 commented Jan 31, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
aduh95 commented Feb 3, 2021
@nodejs/documentation @nodejs/website wdyt? |
nodejs-github-bot commented Feb 23, 2021
nodejs-github-bot commented Feb 23, 2021
aduh95 commented Feb 23, 2021
Adding the blocked label, as this implementation is probably going to conflict with the next linter update. I'll update this once nodejs/remark-preset-lint-node#176 lands on nodejs/node master. |
d3915e0 to 39f1184Compareaduh95 commented Mar 4, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
jasnell commented Mar 4, 2021
#37604 has landed now :-) |
39f1184 to 886be29Compare5c79ba2 to 2e1e74eCompareaduh95 commented Mar 6, 2021
Landed in 2e1e74e |
Signed-off-by: James M Snell <[email protected]> PR-URL: #37594 Refs: #37162 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37605 Refs: #37162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax. It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other. PR-URL: #37162 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37594 Refs: #37162 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Signed-off-by: James M Snell <[email protected]> PR-URL: #37594 Refs: #37162 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax. It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other. PR-URL: #37162 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax. It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other. PR-URL: #37162 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax. It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other. PR-URL: #37162 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax. It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other. PR-URL: #37162 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37605 Refs: nodejs#37162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37605 Refs: nodejs#37162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37605 Refs: nodejs#37162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37605 Refs: #37162 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Enable code example using both modern ESM syntax and legacy CJS syntax.
It adds a toggle on the web interface to let users switch from one JavaScript flavor to the other.
html.jsdetects code snippets with a meta attribute:And adds a
<input type=checkbox>toggle:With dark mode on
Originally suggested by @jasnell in #37077 (comment).