doc: crypto esm examples

[jasnell]

Add ESM examples to crypto docs in preparation for #37162 landing.

Blocked for now until nodejs/remark-preset-lint-node#176 lands.

Refs: #37162

/cc @aduh95

Signed-off-by: James M Snell [email protected]

[Trott]

Should be unblocked once #37604 lands.

[aduh95]

@jasnell I've pushed updates to your branch to use mjs instead of js esm.

[jasnell]

I've pushed updates to your branch to use mjs instead of js esm.

Thank you! :-)

[aduh95]

As with #37607, non blocking comments.

For some reason my brain sees no issue with named import for crypto (same as fs), but there's something special with assert 🤷‍♂️

[panva]

I think the examples should use the lexical import keyword.

• Are builds without crypto that common that all esm samples need to account for crypto missing?
• cjs -> esm transition is ongoing and top level await import('crypto') cannot be transpiled to CJS, the samples will be a source of frustration for developers when used in their code.

[jasnell]

Are builds without crypto that common that all esm samples need to account for crypto missing?

Likely not but I'd rather that folks look at this and ask why it's different than be surprised later when it doesn't work. And, to be fair, I'd like to use this as a good reason to revisit how we do this -- I'd much rather the crypto module not throw on load, and would instead just throw if any of the APIs are actually called.

[benjamingr]

I went over most of these examples, I only tried running a few. It would be really cool if our examples ran

[jasnell]

@panva ... Would you mind if we went ahead with this PR as is (using the import() function instead of lexical import) then made the switch over to lexical once the code is changed to not throw on load?

[panva]

@panva ... Would you mind if we went ahead with this PR as is (using the import() function instead of lexical import) then made the switch over to lexical once the code is changed to not throw on load?

👍

[jasnell]

Landed in bfa6e37