test: rename n-api to node-api#37217
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
BethGriggs approved these changes Feb 4, 2021
marsonya approved these changes Feb 4, 2021
Collaborator
nodejs-github-bot commented Feb 5, 2021
Collaborator
nodejs-github-bot commented Feb 6, 2021
Trott approved these changes Feb 6, 2021
This renames the macros used in the tests from `NAPI_*` to `NODE_API_*`. PR-URL: nodejs#37217 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Feb 6, 2021
Landed in 4b7f23f |
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
This renames the macros used in the tests from `NAPI_*` to `NODE_API_*`. PR-URL: #37217 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Contributor
danielleadams commented Apr 28, 2021
@gabrielschulhof do you mind opening a 14.x backport PR? There are failing tests when these changes are pulled in. |
This was referenced Jul 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the macros used in the tests from
NAPI_*toNODE_API_*.