node-api: avoid crashing on passed-in null string#38923
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added c++ 
gabrielschulhof added node-api 
When `napi_create_string_*` receives a null pointer as its second argument, it must null-check it before passing it into V8, otherwise a crash will occur. Signed-off-by: Gabriel Schulhof <[email protected]>
gabrielschulhofforce-pushed the node-api-fix-string-null branch from e86316d to b5dc717Compare
bl-ue approved these changes Jun 4, 2021
addaleax requested changes Jun 5, 2021
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
str should be allowed to be nullptr if length is 0.
ContributorAuthor
gabrielschulhof commented Jun 7, 2021
@addaleax I added an allowance for NULL when the length given is zero. PTAL! |
addaleax approved these changes Jun 7, 2021
legendecas approved these changes Jun 7, 2021
Collaborator
nodejs-github-bot commented Jun 7, 2021
jasnell reviewed Jun 7, 2021
| napi_value* result){ | ||
| CHECK_ENV(env); | ||
| if (length > 0) | ||
| CHECK_ARG(env, str); |
Member
There was a problem hiding this comment.
The naming of these macros is really unfortunate. Everywhere else, CHECK_* generally implies an assert.
jasnell approved these changes Jun 7, 2021
fhinkel approved these changes Jun 8, 2021
Member
mhdawson commented Jun 10, 2021
Resume attemp: https://ci.nodejs.org/job/node-test-pull-request/38563/ |
Collaborator
nodejs-github-bot commented Jun 10, 2021
gabrielschulhof added a commit that referenced this pull request Jun 11, 2021
When `napi_create_string_*` receives a null pointer as its second argument, it must null-check it before passing it into V8, otherwise a crash will occur. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #38923 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ContributorAuthor
gabrielschulhof commented Jun 11, 2021
Landed in d615aeb. |
danielleadams pushed a commit that referenced this pull request Jun 13, 2021
When `napi_create_string_*` receives a null pointer as its second argument, it must null-check it before passing it into V8, otherwise a crash will occur. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #38923 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
When `napi_create_string_*` receives a null pointer as its second argument, it must null-check it before passing it into V8, otherwise a crash will occur. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #38923 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Member
richardlau commented Jul 19, 2021
This is blocked from landing on v14.x-staging as it depends on #37217. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
napi_create_string_*receives a null pointer as its secondargument, it must null-check it before passing it into V8, otherwise a
crash will occur.
Signed-off-by: @gabrielschulhof