Skip to content

Conversation

@aduh95
Copy link
Contributor

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 16, 2021
@LxxyxLxxyx assigned Lxxyx and unassigned LxxyxFeb 18, 2021
@nodejs-github-bot

This comment has been minimized.

@LxxyxLxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@aduh95aduh95force-pushed the uri-handling-primoordials branch from 408f359 to b7a593dCompareFebruary 18, 2021 19:08
@aduh95
Copy link
ContributorAuthor

Landed in b7a593d

@aduh95aduh95 merged commit b7a593d into nodejs:masterFeb 18, 2021
@aduh95aduh95 deleted the uri-handling-primoordials branch February 18, 2021 19:09
targos pushed a commit that referenced this pull request Feb 28, 2021
PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Mar 2, 2021
richardlau pushed a commit to aduh95/node that referenced this pull request Mar 29, 2021
PR-URL: nodejs#37394 Backport-PR-URL: nodejs#37859 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@richardlaurichardlau mentioned this pull request Mar 29, 2021
targos pushed a commit that referenced this pull request May 27, 2021
PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #37394 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@jasnell@Lxxyx@richardlau