[v12.x backport] module: improve support of data: URLs#37859
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
Collaborator
nodejs-github-bot commented Mar 22, 2021
Member
richardlau commented Mar 22, 2021
cc @nodejs/lts Any concerns with adding URI handling functions to primordials in 12.x? |
Collaborator
nodejs-github-bot commented Mar 22, 2021
richardlau approved these changes Mar 29, 2021
PR-URL: nodejs#37394 Backport-PR-URL: nodejs#37859 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add support for loading modules using percent-encoded URLs. PR-URL: nodejs#37392 Backport-PR-URL: nodejs#37859 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
richardlauforce-pushed the backport-data-url-v12.x branch from 3f6e97e to 7b0ed4bCompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37392.
I've also included #37394 which simply adds
decodeURIComponentto primordials, but we could also leave it out and use it from the global object.