deps: update V8 to 9.0#37587

targos · 2021-03-03T17:00:20Z

ETA: Tue, Apr 13, 2021

targos · 2021-03-03T17:01:01Z

CI running at https://ci.nodejs.org/job/node-test-commit/44792/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3819/

aduh95 · 2021-03-04T10:27:39Z

Should we keep f26c461 and dd99628 considering we now require XCode ≥10? Ditto for 22be529 as we require VS ≥2019.

node/BUILDING.md

Lines 158 to 166 in 7a4c2c8

### Supported toolchains
 Depending on the host platform, the selection of toolchains may vary. 
| Operating System | Compiler Versions |
| ---------------- | -------------------------------------------------------------- |
| Linux | GCC >= 6.3 |
| Windows | Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host |
| macOS | Xcode >= 10 (Apple LLVM >= 10) |

targos · 2021-03-04T10:56:27Z

I'll try to remove the XCode patches.
We still support Visual Studio 2015 for building addons. See #37472

nodejs-github-bot · 2021-03-04T11:20:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36467/

targos · 2021-03-04T12:23:49Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2642/

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.0. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. [email protected],[email protected],[email protected] CC=[email protected] Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Commit-Queue: Tamer Tas <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Fixes a compilation issue on some platforms PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

PR-URL: nodejs#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Original commit message: torque: workaround stod() limitations on Solaris std::stod() on Solaris does not currently handle hex strings. This commit provides a workaround based on strtol() until proper stod() support is available. This was encountered while updating Node.js to V8 8.8. For more details see the following comment: nodejs#36139 (comment) Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746 Reviewed-by: Michael Stanton <[email protected]> Commit-Queue: Michael Stanton <[email protected]> Cr-Commit-Position: refs/heads/master@{#73255} Refs: v8/v8@1648e05

The script versions are no longer available.

V8 has removed argument adapter frames. This commit removes them from the Node.js codebase as well.

Fixes: nodejs/node-v8#193

nodejs-github-bot · 2021-03-12T08:18:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36648/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3834/

PR-URL: nodejs/node#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added the v8 engine Issues and PRs related to the V8 dependency. label Mar 3, 2021

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 3, 2021

targos added semver-major PRs that contain breaking changes and should be released in the next major version. and removed build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 3, 2021

targos force-pushed the v8-90 branch from f5fda5b to 92f1ceeCompare March 8, 2021 08:50

targos mentioned this pull request Mar 10, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged

targosand others added 15 commits March 12, 2021 08:24

deps: update V8 to 9.0.257.11
42b4168

build: reset embedder string to "-node.0"
5907176

src: update NODE_MODULE_VERSION to 93
7669aa9
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.0. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: V8: patch register-arm64.h
2ed3e1b
Fixes a compilation issue on some platforms PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

deps: silence irrelevant V8 warnings
f89e610

src: use non-deprecated V8 module APIs
0bf6e1e

lib: load v8_prof_processor dependencies as ESM
2ab93a5
The script versions are no longer available.

tools: update V8 gypfiles for 9.0
62710da

src: remove V8_FT_ADAPTOR for V8 update
a47f565
V8 has removed argument adapter frames. This commit removes them from the Node.js codebase as well.

src: use non-deprecated GetCreationContext from V8
430c7ee
Fixes: nodejs/node-v8#193

targos force-pushed the v8-90 branch from 92f1cee to 430c7eeCompare March 12, 2021 07:36

targos added a commit to targos/node that referenced this pull request Jan 18, 2022
deps: silence irrelevant V8 warning
4b7bc93
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit that referenced this pull request Jan 20, 2022
deps: silence irrelevant V8 warning
9fef7a1
PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Jan 20, 2022
deps: silence irrelevant V8 warning
850c0f1
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit that referenced this pull request Jan 20, 2022
deps: silence irrelevant V8 warning
2f405cb
PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Jan 29, 2022
deps: silence irrelevant V8 warning
242c7ea
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
deps: silence irrelevant V8 warning
51db5df
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Feb 1, 2022
deps: silence irrelevant V8 warning
ae1ce81
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit that referenced this pull request Feb 2, 2022
deps: silence irrelevant V8 warning
c19ec06
PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Feb 2, 2022
deps: silence irrelevant V8 warning
0f09612
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
deps: silence irrelevant V8 warning
9a244cc
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Feb 23, 2022
deps: silence irrelevant V8 warning
ca081b9
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Mar 1, 2022
deps: silence irrelevant V8 warning
7856f97
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Mar 7, 2022
deps: silence irrelevant V8 warning
350c9e3
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

targos added a commit to targos/node that referenced this pull request Mar 17, 2022
deps: silence irrelevant V8 warning
47e80dc
PR-URL: nodejs#37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

deps: update V8 to 9.0#37587

deps: update V8 to 9.0 #37587

Uh oh!

targos commented Mar 3, 2021

Uh oh!

targos commented Mar 3, 2021•
edited
Loading

Uh oh!

aduh95 commented Mar 4, 2021

Uh oh!

targos commented Mar 4, 2021

Uh oh!

nodejs-github-bot commented Mar 4, 2021

Uh oh!

targos commented Mar 4, 2021

Uh oh!

nodejs-github-bot commented Mar 12, 2021•
edited by targos
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

deps: update V8 to 9.0#37587

deps: update V8 to 9.0 #37587

Uh oh!

Conversation

targos commented Mar 3, 2021

Uh oh!

targos commented Mar 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Mar 4, 2021

Uh oh!

targos commented Mar 4, 2021

Uh oh!

nodejs-github-bot commented Mar 4, 2021

Uh oh!

targos commented Mar 4, 2021

Uh oh!

nodejs-github-bot commented Mar 12, 2021• edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

targos commented Mar 3, 2021•
edited
Loading

nodejs-github-bot commented Mar 12, 2021•
edited by targos
Loading