tools: take ownership of deps/v8/tools/node#39222
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The files are not maintained nor used upstream anymore.
github-actionsbot added meta 
victorgomes commented Jul 1, 2021
Thanks @targos! It looks good to me. 😊 |
richardlau approved these changes Jul 1, 2021
MemberAuthor
targos commented Jul 2, 2021
Change that removes the files from V8: https://chromium-review.googlesource.com/c/v8/v8/+/3000966 |
MemberAuthor
targos commented Jul 2, 2021
gengjiawen approved these changes Jul 2, 2021
cjihrig approved these changes Jul 4, 2021
targos added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39222 ✔ Done loading data for nodejs/node/pull/39222 ----------------------------------- PR info ------------------------------------ Title tools: take ownership of deps/v8/tools/node (#39222) Author Michaël Zasso (@targos) Branch targos:v8-tools-node -> nodejs:master Labels meta, needs-ci, tools, v8 engine Commits 1 - tools: take ownership of deps/v8/tools/node Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/39222 Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39222 Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 01 Jul 2021 15:51:39 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/39222#pullrequestreview-697525079 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39222#pullrequestreview-697851706 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39222#pullrequestreview-698688392 ✔ Last GitHub Actions successful ✖ No full Jenkins CI runs detected ℹ Last V8 CI on 2021-07-02T05:47:38Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4098/ - Querying data for job/node-test-pull-request/4098/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1001572344 |
github-actionsbot added the commit-queue-failed github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 5, 2021
Collaborator
nodejs-github-bot commented Jul 5, 2021
gengjiawen added commit-queue github-actionsbot removed the commit-queue Contributor
Landed in 953860b...d45e0eb |
nodejs-github-bot pushed a commit that referenced this pull request Jul 6, 2021
The files are not maintained nor used upstream anymore. PR-URL: #39222 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
pullbot pushed a commit to ashu8912/v8 that referenced this pull request Jul 7, 2021
These scripts are not used nor maintained anymore by V8. We use https://chromium.googlesource.com/v8/node-ci/. Node.js is now taking ownership of these scripts: nodejs/node#39222 Change-Id: I5600f3725d1ff9f78733952e5905faef0195a188 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3000966 Auto-Submit: Victor Gomes <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Commit-Queue: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/master@{#75596}
targos added a commit that referenced this pull request Jul 11, 2021
The files are not maintained nor used upstream anymore. PR-URL: #39222 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files are not maintained nor used upstream anymore.
/cc @nodejs/v8-update @victorgomes