Skip to content

tools: add double-quotes to make-v8.sh#41257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 22, 2021
Merged

tools: add double-quotes to make-v8.sh #41257

nodejs-github-bot merged 1 commit into from
Dec 22, 2021

Conversation

@Trott
Copy link
Member

@TrottTrott commented Dec 21, 2021•
edited
Loading

Now that we maintain make-v8.sh rather than pull it from upstream, we
can make it conform to our shellcheck lint checks.

This is not being flagged in CI because (I'm guessing) shellcheck in CI
is 0.7.0 but latest is 0.8.0.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 21, 2021
@richardlau
Copy link
Member

richardlau commented Dec 21, 2021

Now that we maintain make-v8.sh rather than pull it from upstream, we can make it conform to our shellcheck lint checks.

FYI This file didn’t come from upstream.

richardlau
richardlau approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@richardlaurichardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. This file is used by the V8 CI job so it would be a good idea to run that with this given previous breakage caused by quoting shell variables in this file (#36099).

@Trott
Copy link
MemberAuthor

Trott commented Dec 21, 2021•
edited
Loading

FYI This file didn’t come from upstream.

I based the comment on a (quick) reading of #39222 which suggested to me that it used to be maintained by an upstream project: "The files are not maintained nor used upstream anymore." I guess my interpretation was not quite right.

@Trott
Copy link
MemberAuthor

Trott commented Dec 21, 2021

This file is used by the V8 CI job so it would be a good idea to run that with this

https://ci.nodejs.org/job/node-test-commit-v8-linux/4439/

@richardlau
Copy link
Member

richardlau commented Dec 21, 2021

FYI This file didn’t come from upstream.

I based the comment on a (quick) reading of #39222 which suggested to me that it used to be maintained by an upstream project: "The files are not maintained nor used upstream anymore."

That comment is referring to these two files from that PR:

which did use to come from upstream (dropped by https://chromium-review.googlesource.com/c/v8/v8/+/3000966).

tools/make_v8.sh was updated in that PR to point to the new location for fetch_deps.py but it has always been a file that we have maintained in this repository.

@Trott
tools: add double-quotes to make-v8.sh
d8bf0e3
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0.
@Trott
Copy link
MemberAuthor

Trott commented Dec 21, 2021

it has always been a file that we have maintained in this repository.

Got it. I've removed that sentence from the commit message.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@Trott
Copy link
MemberAuthor

Trott commented Dec 21, 2021

This file is used by the V8 CI job so it would be a good idea to run that with this

https://ci.nodejs.org/job/node-test-commit-v8-linux/4439/

V8 CI is green.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41583/

@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions
Copy link
Contributor

github-actionsbot commented Dec 21, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41590/

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 21, 2021
@github-actionsgithub-actionsbot mentioned this pull request Dec 22, 2021
Open
21 tasks
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
@nodejs-github-botnodejs-github-bot merged commit 9e1a080 into nodejs:masterDec 22, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021

Landed in 9e1a080

@TrottTrott deleted the v8-sh branch December 22, 2021 04:26
This was referenced Dec 23, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actionsgithub-actionsbot mentioned this pull request Dec 30, 2021
Open
27 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott@targos
tools: add double-quotes to make-v8.sh
e2df381
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: #41257 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott@danielleadams
tools: add double-quotes to make-v8.sh
12cbded
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: #41257 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott@Linkgoron
tools: add double-quotes to make-v8.sh
cbfea63
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: nodejs#41257 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: add double-quotes to make-v8.sh
1523aa5
This is not being flagged in CI because (I'm guessing) shellcheck in CI is 0.7.0 but latest is 0.8.0. PR-URL: #41257 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@richardlau@nodejs-github-bot@jasnell@lpinca@targos@cjihrig