doc(async_hooks): fix imports in context example#39229
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added async_hooks 
yashLadhaforce-pushed the fix_async_hooks_context_docs branch from e54ee54 to 5b91b6bCompare
jasnell approved these changes Jul 8, 2021
targos approved these changes Jul 9, 2021
Member
RaisinTen left a comment
RaisinTen left a comment There was a problem hiding this comment.
Should we be doing this given #38382 (comment)? cc @aduh95
Added imports for packages that is mentioned in the example of async_hooks context example.
Flarnaforce-pushed the fix_async_hooks_context_docs branch from 5b91b6b to e8d2176Compare
Flarna approved these changes Feb 3, 2022
Flarna added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Feb 3, 2022
Landed in 0f84217 |
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
Added imports for packages that is mentioned in the example of async_hooks context example. PR-URL: nodejs#39229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Added imports for packages that is mentioned in the example of async_hooks context example. PR-URL: #39229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Added imports for packages that is mentioned in the example of async_hooks context example. PR-URL: #39229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Added imports for packages that is mentioned in the example of async_hooks context example. PR-URL: #39229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Added imports for packages that is mentioned in the example of async_hooks context example. PR-URL: #39229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed imports of certain packages required to run the example.