Skip to content

Conversation

@ruyadorno
Copy link
Member

@ruyadornoruyadorno commented Feb 8, 2022

2022-02-10, Version 17.5.0 (Current), @ruyadorno

Notable Changes

Add fetch API

Adds experimental support to the fetch API. This adds a --experimental-fetch
flag that installs the fetch, Request, Reponse and Headers globals.

Add stream methods

  • [1ae648567a] - (SEMVER-MINOR)stream: add iterator helper find (linkgoron) #41849
  • [62e1a68077] - (SEMVER-MINOR)stream: add toArray (Benjamin Gruenbaum) #41553
  • [da11b95988] - (SEMVER-MINOR)stream: add forEach method (Benjamin Gruenbaum) #41445
  • [34684a1c89] - (SEMVER-MINOR)stream: support some and every (Benjamin Gruenbaum) #41573

Other Notable Changes

Commits

cc @nodejs/releasers

nodejs-github-botand others added 30 commits January 24, 2022 17:35
PR-URL: #41548 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
This statement is misleading in that it says "key generation is expensive". ECDHE key generation (over the elliptic curves that are commonly used for TLS) is insanely fast compared to most other types of key generation. This statement is irrelevant for TLS 1.3, which requires (EC)DHE. Even if this statement is somewhat true for TLS 1.2, it does not justify discouraging the use of (EC)DHE. PR-URL: #41528 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
`hash.digest('buffer')` has returned a Buffer and not a string since at least Node.js 0.10.6. The benchmark, as it is written, will not work on any version of Node.js prior to 16.x (due to `Object.hasOwn()`) and certainly won't run on versions earlier than 0.10.6 due to const/let and probably other things. Remove impossible-to-reach code intended to accommodate Node.js earlier than 0.10.6. PR-URL: #41535 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Instead of assigning a boolean, move the function call that assigns a value to the boolean to the only place that boolean is checked. This avoids the function call in cases where it is not needed. Refs: #41488 (review) PR-URL: #41534 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Coverage stats indicate that there is no coverage for util.inspect() with a negative number and a numeric separator. Add a test case. Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 PR-URL: #41527 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
 Refs: #41345 (comment) PR-URL: #41383 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Add a `forEach` method to readable streams to enable concurrent iteration and align with the iterator-helpers proposal. Co-Authored-By: Robert Nagy <[email protected]> PR-URL: #41445 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #41542 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
This is part of an effort to get our code to comply with ESLint no-cond-assign so that we don't have to disable that rule in our config. PR-URL: #41510 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #41499 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Adrian Estrada <[email protected]>
Refs: #41433 (comment) PR-URL: #41486 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Noticed that a few assertions were not being awaited, this could potentially be leading to flakiness in tmp cleanup. Refs: #41201 PR-URL: #41545 Refs: #41201 Reviewed-By: Ian Sutherland <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Replaced the entries with keys since the values of the entries are not used, and changed loop style to avoid mangled `Symbol.iterator`s and to keep consistency. PR-URL: #41482 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41570 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Co-authored-by: Rich Trott <[email protected]> PR-URL: #41549 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the 'data' argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView. PR-URL: #41556 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Update to @rollup/[email protected], [email protected], and [email protected]. PR-URL: #41440 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #33889 PR-URL: #41577 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
PR-URL: #41560 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
This syncs up the source list in https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/uv.gyp#L257-L265 with https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/CMakeLists.txt#L218-L227. Fixes: #41380 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41555 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41515 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Make the text more concise and clear. PR-URL: #41550 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #41381 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
There are been several discussions in recent PRs about the docs related to contributing not being very discoverable. Move these docs from doc/guides/ to doc/contributing. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41408 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41323 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Today, the global uncaught exception handler is the only place where asyncId 0 is not ignored and we still proceed to call emitAfter. This would've already failed one of our correctness tests in async_hooks if not for some other code meant to handle a different edge case. Fixes: #22982 PR-URL: #41424 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #41584 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #41446 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #41487 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@RaisinTenRaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836) PR-URL: #41897
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 10, 2022

@VoltrexKeyvaVoltrexKeyva added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Feb 10, 2022
@ruyadornoruyadorno merged commit b290a87 into v17.xFeb 10, 2022
ruyadorno added a commit that referenced this pull request Feb 10, 2022
ruyadorno added a commit that referenced this pull request Feb 10, 2022
Notable changes: lib: * (SEMVER-MINOR) add fetch (Michaël Zasso) #41749 module: * unflag esm json modules (Geoffrey Booth) #41736 node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) #41329 stream: * (SEMVER-MINOR) add iterator helper find (linkgoron) #41849 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) #41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) #41445 * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) #41573 deps: * upgrade npm to 8.4.1 (npm team) [#41836](#41836) PR-URL: #41897
ruyadorno added a commit to ruyadorno/nodejs.org that referenced this pull request Feb 10, 2022
ruyadorno added a commit to nodejs/nodejs.org that referenced this pull request Feb 10, 2022
@ruyadornoruyadorno deleted the v17.5.0-proposal branch February 10, 2022 19:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releaseIssues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@ruyadorno@nodejs-github-bot@aduh95@bricss@mcollina@cjihrig@tniessen@richardlau@danielleadams@RaisinTen@VoltrexKeyva@Trott@benjamingr@yu521088@Mesteery@mhdawson@shipujin@apapirovski@JakobJingleheimer@qdaoming