Docs: should give a descriptive information about the process.platform property & os.platform() function#41650
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
twitharshil changed the title twitharshilforce-pushed the feature/update-doc branch 3 times, most recently from 6637a0c to ea5d83fCompare
Member
Trott commented Jan 22, 2022
Welcome, @twitharshil, and thanks for the pull request. You'll need to wrap these at 80 characters for the linter to pass. |
twitharshilforce-pushed the feature/update-doc branch from ea5d83f to c277908Compare
twitharshilforce-pushed the feature/update-doc branch from c277908 to c7ee87eCompare
ContributorAuthor
twitharshil commented Jan 23, 2022
@Trott Done, Thanks! :) |
aduh95 approved these changes Jan 23, 2022
aduh95 added the author ready 
Mesteery approved these changes Jan 23, 2022
bnb approved these changes Jan 25, 2022
aduh95 added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Jan 28, 2022
Landed in a4183b6 |
Contributor
aduh95 commented Jan 28, 2022
Thanks for the contribution 🎉 |
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41650 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process.platform & Os.platform() values are being set at the compile time for nodeJS Ref
We should be mentioning it clearly on the docs, as we do the same for the process.arch