domain: pass opts to EventEmitter.init#41414
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added domain 
cjihrig approved these changes Jan 6, 2022
ZYSzys approved these changes Jan 6, 2022
apapirovski approved these changes Jan 6, 2022
Uh oh!
There was an error while loading. Please reload this page.
aduh95 approved these changes Jan 6, 2022
aduh95 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jan 6, 2022
This was referenced Jan 7, 2022
22 tasks
Collaborator
nodejs-github-bot commented Jan 14, 2022
26 tasks
Collaborator
nodejs-github-bot commented Jan 17, 2022
16 tasks
Collaborator
nodejs-github-bot commented Jan 18, 2022
13 tasks
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 19, 2022
Landed in 22792c8 |
17 tasks
CMCDragonkai commented Jan 20, 2022
Are fixes like these ever backported or only to LTS? |
Contributor
aduh95 commented Jan 20, 2022
This is semver-patch, it should be automatically backported to v17.x. Once there's a v17.x version with this change, it should be automatically backported to v16.x two weeks after that. If a conflict arises that blocks the backport, the backporter team usually comments on the issue asking for a manual backport. |
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41414Fixes: #41391 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41414Fixes: nodejs#41391 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
PR-URL: #41414Fixes: #41391 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41414Fixes: #41391 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41414Fixes: #41391 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
domainmodule override theEventEmitter.initbut not pass the params to origin function.Since
replmodule requiredomainmodule, the root cause of #41391 is indomainmodule.Fixes: #41391