src: fix typo in js_native_api_v8.cc#41764
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 30, 2022
Review requested:
|
nodejs-github-bot added c++ 
Mesteery approved these changes Jan 30, 2022
addaleax approved these changes Jan 30, 2022
addaleax added request-ci 
RaisinTen approved these changes Jan 30, 2022
github-actionsbot removed the request-ci This comment has been minimized.
This comment has been minimized.
richardlau approved these changes Jan 30, 2022
tniessen approved these changes Jan 30, 2022
Collaborator
nodejs-github-bot commented Jan 30, 2022
cjihrig approved these changes Jan 30, 2022
VoltrexKeyva approved these changes Jan 30, 2022
28 tasks
lpinca approved these changes Jan 31, 2022
Mesteery added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 31, 2022
Commit Queue failed- Loading data for nodejs/node/pull/41764 ✔ Done loading data for nodejs/node/pull/41764 ----------------------------------- PR info ------------------------------------ Title src: fix typo in js_native_api_v8.cc (#41764) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch caioagiani:patch-1 -> nodejs:master Labels c++ Commits 1 - src: fix typo in js_native_api_v8.cc Committers 1 - caioagiani PR-URL: https://github.com/nodejs/node/pull/41764 Reviewed-By: Mestery Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41764 Reviewed-By: Mestery Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 30 Jan 2022 03:46:18 GMT ✔ Approvals: 8 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41764#pullrequestreview-867072126 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41764#pullrequestreview-867091112 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867094356 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867110760 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867193237 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867199780 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41764#pullrequestreview-867235295 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41764#pullrequestreview-868370661 ✖ This PR needs to wait 6 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-30T19:05:07Z: https://ci.nodejs.org/job/node-test-pull-request/42247/ - Querying data for job/node-test-pull-request/42247/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1774881296 |
nodejs-github-bot added the commit-queue-failed This was referenced Feb 1, 2022
gengjiawen approved these changes Feb 2, 2022
gengjiawen added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 2, 2022
Landed in 4318b23 |
41 tasks
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
PR-URL: nodejs#41764 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
38 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41764 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41764 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41764 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41764 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/js_native_api_v8.ccNAPI_AUTO_LENGHTH → NAPI_AUTO_LENGTH