doc: add steam pipelining note on Http usage#41796
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Uh oh!
There was an error while loading. Please reload this page.
ronag reviewed Jan 31, 2022
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSSforce-pushed the doc/add-stream-pipeline-advice branch 2 times, most recently from fb8c5a9 to 7f235dcCompareronag approved these changes Jan 31, 2022
mmarchini approved these changes Feb 1, 2022
Contributor
mmarchini left a comment
mmarchini left a comment There was a problem hiding this comment.
nit: replace steam with stream in commit message
RafaelGSSforce-pushed the doc/add-stream-pipeline-advice branch from 7f235dc to fd7932dCompare
Collaborator
nodejs-github-bot commented Feb 2, 2022
41 tasks
Collaborator
nodejs-github-bot commented Feb 3, 2022
lpinca reviewed Feb 3, 2022
| failure, this can cause event listener leaks and swallowed errors. | ||
| `stream.pipeline()` closes all the streams when an error is raised. | ||
| The `IncomingRequest` usage with `pipeline` could lead to an unexpected behavior |
Member
There was a problem hiding this comment.
What is IncomingRequest? Did you mean IncomingMessage? In the example below res is a ServerResponse or OutgoingMessage.
MemberAuthor
There was a problem hiding this comment.
Actually, I meant an Incoming Request in general. The idea is to show that a socket/request usage with pipeline could lead to a error
This was referenced Feb 4, 2022
jasnell approved these changes Feb 5, 2022
27 tasks
mcollina added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Feb 6, 2022
Landed in 1c7a74e |
29 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
PR-URL: nodejs#41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
PR-URL: nodejs#41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
PR-URL: #41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41796 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address: #26311
Reference: #41137
cc/@ronag@mcollina