test: replace commented out expectations with tests#41667
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
This comment has been minimized.
This comment has been minimized.
Mesteery approved these changes Jan 23, 2022
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Darshan Sen <[email protected]>
RaisinTenforce-pushed the test/replace-commented-out-expectations-with-tests branch from 1a20417 to e8042e0Compare This comment has been minimized.
This comment has been minimized.
RaisinTen added the author ready 
Trott approved these changes Jan 23, 2022
Collaborator
nodejs-github-bot commented Jan 23, 2022
lpinca approved these changes Jan 23, 2022
22 tasks
tniessen approved these changes Jan 24, 2022
This was referenced Jan 25, 2022
jasnell approved these changes Jan 28, 2022
RaisinTen added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 29, 2022
Landed in ef4c115 |
RaisinTen deleted the test/replace-commented-out-expectations-with-tests branch Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#41667 Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41667 Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41667 Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41667 Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #41667 Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen [email protected]