Skip to content

Conversation

@Trott
Copy link
Member

No description provided.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 17, 2022
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2022
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022
@nodejs-github-bot

This comment has been minimized.

Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't a bot usually handle this now?

@Trott
Copy link
MemberAuthor

Trott commented Jan 17, 2022

LGTM, but doesn't a bot usually handle this now?

Yes, usually, but the ESLint release came out later than they usually do and so the weekly bot run missed it. I supposed I could have dispatched the workflow manually, though.

@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

Rubber-stamp LGTM

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-botnodejs-github-bot merged commit 6beee31 into nodejs:masterJan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6beee31

thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
PR-URL: nodejs#41570 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41570 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41570 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
PR-URL: #41570 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@TrottTrott deleted the eslint-8.7.0 branch September 25, 2022 17:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@nodejs-github-bot@jasnell@lpinca@targos@cjihrig@tniessen@Mesteery@VoltrexKeyva