test: make worker-take-heapsnapshot non-flaky#41684
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
MemberAuthor
mhdawson commented Jan 24, 2022
For more details see #41204 |
richardlau approved these changes Jan 24, 2022
benjamingr approved these changes Jan 24, 2022
Trott approved these changes Jan 25, 2022
Member
Trott left a comment
Trott left a comment There was a problem hiding this comment.
Maybe add a Closes: https://github.com/nodejs/node/issues/41204 to the commit message?
lpinca approved these changes Jan 25, 2022
Collaborator
nodejs-github-bot commented Jan 25, 2022
RaisinTen approved these changes Jan 25, 2022
Member
RaisinTen left a comment
RaisinTen left a comment There was a problem hiding this comment.
Can we backport this to v14.x?
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: nodejs#41204 Signed-off-by: Michael Dawson <[email protected]>
MemberAuthor
mhdawson commented Jan 25, 2022
@RaisinTen I don't think we ever backported the original exclude to any of the released lines as the CI does not run the arm-debug step except for on the main branch. |
MemberAuthor
mhdawson commented Jan 25, 2022
@Trott I don't think a closes makes sense the issue still exists for some of the older lines. I will add a Refs: though. |
MemberAuthor
mhdawson commented Jan 25, 2022
Added the refs |
Collaborator
nodejs-github-bot commented Jan 25, 2022
26 tasks
Collaborator
nodejs-github-bot commented Jan 26, 2022
30 tasks
Collaborator
nodejs-github-bot commented Jan 27, 2022
22 tasks
Collaborator
nodejs-github-bot commented Jan 28, 2022
Collaborator
nodejs-github-bot commented Jan 28, 2022
jasnell approved these changes Jan 28, 2022
This was referenced Jan 29, 2022
Collaborator
nodejs-github-bot commented Jan 31, 2022
mhdawson added a commit that referenced this pull request Jan 31, 2022
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: #41204 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41684 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
mhdawson commented Jan 31, 2022
Landed in 0ff62b4 |
31 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: #41204 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41684 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: #41204 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41684 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: #41204 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41684 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Recent V8 upgrade seems to have made this pass reliably now. Remove flaky entry Refs: #41204 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41684 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent V8 upgrade seems to have made this pass
reliably now. Remove flaky entry
Signed-off-by: Michael Dawson [email protected]