Skip to content

doc: add note about resource type in async_hooks#41797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 5 commits into from
Feb 3, 2022
Merged

doc: add note about resource type in async_hooks #41797

nodejs-github-bot merged 5 commits into from
Feb 3, 2022

Conversation

@tony-go
Copy link
Member

@tony-gotony-go commented Jan 31, 2022

Hi everyone 👋

During the last Diagnostic WG meeting, the question has been raised of the type argument interface (async_hooks / init hook).

The initial demand was to document more precisely each type. But @bmeckmentions that this list of identifiers described in the documentation could arbitrarily change.

So, this pull request contains a note to explicitly tell users what is the status of these identifiers.

CC @RafaelGSS / @gireeshpunathil

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 31, 2022
@Trott
Copy link
Member

Trott commented Feb 1, 2022•
edited by Mesteery
Loading

Welcome @tony-go and thanks for the pull request. Are you able to edit the first commit message? The first word after doc: should be a verb so perhaps this? doc: add note about resource type

@tony-gotony-goforce-pushed the async-hooks-doc-type branch from cdbda7b to e1aff5cCompareFebruary 1, 2022 10:12
@tony-go
Copy link
MemberAuthor

tony-go commented Feb 1, 2022

Thanks for the feedback @Trott 🙌.

Let me know if it's good now.

RafaelGSS
RafaelGSS approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@RafaelGSSRafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS
Copy link
Member

RafaelGSS commented Feb 1, 2022

cc: @Qard

Qard
Qard approved these changes Feb 1, 2022
View reviewed changes
@TrottTrott changed the title doc: async_hooks - add note about resource typedoc: add note about resource type in async_hooksFeb 1, 2022
Trott
Trott reviewed Feb 1, 2022
View reviewed changes
Trott
Trott reviewed Feb 1, 2022
View reviewed changes
@tony-gotony-go requested a review from TrottFebruary 1, 2022 20:50
Trott
Trott reviewed Feb 1, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@RaisinTenRaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2022
@Trott
Copy link
Member

Trott commented Feb 2, 2022

@nodejs/async_hooks

Flarna
Flarna reviewed Feb 2, 2022
View reviewed changes
@FlarnaFlarna added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-botnodejs-github-bot merged commit 064783c into nodejs:masterFeb 3, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 3, 2022

Landed in 064783c

VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
@tony-go@VoltrexKeyva
doc: add note about resource type in async_hooks
3f076dd
PR-URL: nodejs#41797 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tony-go@ruyadorno
doc: add note about resource type in async_hooks
4db343b
PR-URL: #41797 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tony-go@danielleadams
doc: add note about resource type in async_hooks
f5e4443
PR-URL: #41797 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tony-go@danielleadams
doc: add note about resource type in async_hooks
e5a6e46
PR-URL: #41797 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tony-go@danielleadams
doc: add note about resource type in async_hooks
44b6927
PR-URL: #41797 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes

@TrottTrottTrott approved these changes

@FlarnaFlarnaFlarna approved these changes

@RafaelGSSRafaelGSSRafaelGSS approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+1 more reviewer

@vdeturckheimvdeturckheimvdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tony-go@Trott@RafaelGSS@nodejs-github-bot@Qard@vdeturckheim@Flarna@RaisinTen