build: enable zoslib installation on z/OS#41493
Closed
+16 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jan 12, 2022
Review requested:
|
nodejs-github-bot added build 
richardlau approved these changes Jan 13, 2022
Member
There was a problem hiding this comment.
Looks okay. It might be beneficial to others if the commit message had a brief description of what zoslib is and why it is required on z/OS.
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. Co-authored-by: Gaby Baghdadi <[email protected]>
alexcfyungforce-pushed the up_setincludedirs_zos branch from 2b6ebac to 4da49bcCompare
26 tasks
jasnell approved these changes Jan 17, 2022
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 17, 2022
16 tasks
Collaborator
nodejs-github-bot commented Jan 18, 2022
13 tasks
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 19, 2022
17 tasks
Collaborator
nodejs-github-bot commented Jan 20, 2022
19 tasks
mhdawson pushed a commit that referenced this pull request Jan 21, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
Member
mhdawson commented Jan 21, 2022
Landed in ec1364b |
This was referenced Jan 22, 2022
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: nodejs#41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
zoslib is a C/C++ runtime library and an extended implementation of the z/OS LE C Runtime Library. PR-URL: #41493 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Co-authored-by: Gaby Baghdadi <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow node.js to find zoslib headers.