Skip to content

readline: improve code coverage for readline promises#41817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Feb 5, 2022
Merged

readline: improve code coverage for readline promises #41817

nodejs-github-bot merged 2 commits into from
Feb 5, 2022

Conversation

@ErickWendel
Copy link
Member

@ErickWendelErickWendel commented Feb 1, 2022•
edited
Loading

It add tests to the readline promises module
Refs: lib/readline/promises.js.html#L42

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 1, 2022
cjihrig
cjihrig approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny nit.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 1, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 1, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42308/

@github-actionsgithub-actionsbot mentioned this pull request Feb 2, 2022
Open
38 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42314/

This was referenced Feb 3, 2022
Open
Open
Open
@benjamingrbenjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-botnodejs-github-bot merged commit 92b85e7 into nodejs:masterFeb 5, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2022

Landed in 92b85e7

This was referenced Feb 6, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@ErickWendel@ruyadorno
readline: improve code coverage for readline promises
cbcf794
PR-URL: #41817 Refs: https://coverage.nodejs.org/coverage-7123a00b03a90862/lib/readline/promises.js.html#L42 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Mar 1, 2022•
edited
Loading

Marking this as backport-blocked-v16.x as this lands on top of #41008, and pulling it in without breaks tests.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@LxxyxLxxyxLxxyx approved these changes

@aduh95aduh95aduh95 approved these changes

+1 more reviewer

@MesteeryMesteeryMesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ErickWendel@nodejs-github-bot@danielleadams@benjamingr@lpinca@cjihrig@Lxxyx@aduh95@Mesteery@targos