Skip to content

doc: demonstrate dangers of buffer.slice()#41628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 21, 2022
Merged

doc: demonstrate dangers of buffer.slice()#41628

nodejs-github-bot merged 1 commit into from
Jan 21, 2022

Conversation

@shalvah
Copy link
Contributor

@shalvahshalvah commented Jan 21, 2022•
edited
Loading

References #41596 (comment)

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jan 21, 2022
@shalvahshalvah mentioned this pull request Jan 21, 2022
Closed
benjamingr
benjamingr approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@benjamingrbenjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a bunch!

@benjamingrbenjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 21, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented Jan 21, 2022

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-botnodejs-github-bot merged commit 0879394 into nodejs:masterJan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2022

Landed in 0879394

@benjamingr
Copy link
Member

benjamingr commented Jan 21, 2022

Thank you for your first contribution to Node.js core @shalvah 🙏

@shalvahshalvah deleted the doc-demonstrate-buffer-slice-dangers branch January 21, 2022 18:48
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@shalvah@BethGriggs
doc: demonstrate dangers of buffer.slice()
174155d
PR-URL: #41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@shalvah@Linkgoron
doc: demonstrate dangers of buffer.slice()
0471363
PR-URL: nodejs#41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@shalvah@danielleadams
doc: demonstrate dangers of buffer.slice()
78d21e3
PR-URL: #41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@shalvah@danielleadams
doc: demonstrate dangers of buffer.slice()
1fd8f67
PR-URL: #41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@shalvah@danielleadams
doc: demonstrate dangers of buffer.slice()
9f056b8
PR-URL: #41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@shalvah@danielleadams
doc: demonstrate dangers of buffer.slice()
0388b9a
PR-URL: #41628 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@aduh95aduh95aduh95 approved these changes

@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes

+2 more reviewers

@evanlucasevanlucasevanlucas approved these changes

@MesteeryMesteeryMesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shalvah@nodejs-github-bot@benjamingr@evanlucas@Trott@aduh95@Mesteery@VoltrexKeyva